signature now returns native type for both python2 and python3#181
Merged
Conversation
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
dougblack
added a commit
that referenced
this pull request
Oct 13, 2014
signature now returns native type for both python2 and python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a bug where the validator would always return false in python3. I noticed the
compute_signaturemethod usesbase64, which returns a bytecode string. Python3 uses unicode strings as default instead, and the two always compare to false. This pull request should fix that.Summary of Changes
utftocompute_signature, which defaults to True in python3 and False in python2utfis True thencomputedwill be coerced to a unicode stringAll tests pass in both python2 and python3, returns the native stringtype for both in interactive prompt, happy to do other checks if needed.