Skip to content

Add some unit test cases#3818

Merged
Benson0224 merged 2 commits into
tronprotocol:developfrom
vivian1912:develop
Jun 10, 2021
Merged

Add some unit test cases#3818
Benson0224 merged 2 commits into
tronprotocol:developfrom
vivian1912:develop

Conversation

@vivian1912
Copy link
Copy Markdown
Contributor

**What does this PR do?
Add some UT cases for VM/trace
Delete a duplicate UT file
Why are these changes required?
This folder has low code coverage rate
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details
image

image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3818 (89cbd73) into develop (08d18f0) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3818      +/-   ##
=============================================
+ Coverage      52.60%   52.81%   +0.20%     
- Complexity      7099     7132      +33     
=============================================
  Files            769      769              
  Lines          43304    43304              
  Branches        4678     4678              
=============================================
+ Hits           22782    22871      +89     
+ Misses         18699    18613      -86     
+ Partials        1823     1820       -3     
Impacted Files Coverage Δ
...tron/common/overlay/discover/node/NodeManager.java 70.06% <0.00%> (-0.69%) ⬇️
.../main/java/org/tron/core/capsule/VotesCapsule.java 59.25% <0.00%> (+14.81%) ⬆️
...main/java/org/tron/core/vm/trace/ProgramTrace.java 44.44% <0.00%> (+25.00%) ⬆️
...a/org/tron/core/vm/trace/ProgramTraceListener.java 93.33% <0.00%> (+60.00%) ⬆️
...rc/main/java/org/tron/core/vm/trace/OpActions.java 80.00% <0.00%> (+72.72%) ⬆️
...uator/src/main/java/org/tron/core/vm/trace/Op.java 93.75% <0.00%> (+93.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d18f0...89cbd73. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@yanghang8612 yanghang8612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@waynercheung waynercheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@Benson0224 Benson0224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benson0224 Benson0224 merged commit ace748c into tronprotocol:develop Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants