Add vscode configurations to make development easier#352
Merged
Conversation
fpetrini15
reviewed
Apr 10, 2024
fpetrini15
reviewed
Apr 16, 2024
fpetrini15
approved these changes
Apr 16, 2024
fpetrini15
left a comment
Contributor
There was a problem hiding this comment.
Tested with a new build and was able to build the python backend successfully. Optional nit.
Beyond that, LGTM! 🚀
krishung5
approved these changes
Apr 16, 2024
krishung5
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that I can also build the backend locally without issues. Thanks Iman, nice improvement!
Contributor
|
Rebuilt with the new changes (works!) but noticed this time around that we get a warning that "TRITON_ENABLE_ENSEMBLE" is unused. |
fpetrini15
suggested changes
Apr 16, 2024
Member
Author
I removed the unused cmake variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can start development on Python backend just by cloning the folder and using dev container.
Some tasks are added for configuration and build.