Skip to content

Update docs for Java 25 requirement - #29221

Merged
electrum merged 1 commit into
trinodb:masterfrom
Aman6744:fix/java25-docs
Apr 28, 2026
Merged

electrum merged 1 commit into
trinodb:masterfrom
Aman6744:fix/java25-docs

Conversation

@Aman6744

@Aman6744 Aman6744 commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

Release 479 upgraded the minimum JDK from 24 to 25 but several documentation pages were not updated.

  • Update Java requirement from 24 to 25 in deployment guide
  • Add --add-modules=jdk.incubator.vector to example jvm.config
  • Update Java documentation links from javase/24 to javase/25 in TLS and resource groups pages

Description

The JDK 25 requirement is enforced in pom.xml (air.java.version=25.0.1), TrinoSystemRequirements.java (Version.parse("25")), and CI (default JDK 25.0.2). However, deployment.md still stated Java 24 was required and Java 25 was "not supported".

Additionally, the documented example jvm.config was missing --add-modules=jdk.incubator.vector. Without this flag, TrinoSystemRequirements.verifyVectorApiEnabled() causes Trino to exit with code 100 at startup. The Vector API is still an incubator module in Java 25 and must be explicitly enabled.

Oracle Java documentation links in tls.md and resource-groups.md also pointed to javase/24 instead of javase/25.

Additional context and related issues

Fixes #29220

The JDK 25 upgrade was introduced in release 479 (#27171). These documentation pages were not updated as part of that change.

Files changed:

  • docs/src/main/sphinx/installation/deployment.md
  • docs/src/main/sphinx/security/tls.md
  • docs/src/main/sphinx/admin/resource-groups.md

Release notes

[x] This is not user-visible or is docs only, and no release notes are required.

  Release 479 upgraded the minimum JDK from 24 to 25 but several
  documentation pages were not updated.

  - Update Java requirement from 24 to 25 in deployment guide
  - Add --add-modules=jdk.incubator.vector to example jvm.config
  - Update Java documentation links from javase/24 to javase/25
    in TLS and resource groups pages
@cla-bot

cla-bot Bot commented Apr 23, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions Bot added the docs label Apr 23, 2026
@Aman6744

Copy link
Copy Markdown
Contributor Author

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Mailed the signed agreement today.

@chenjian2664

Copy link
Copy Markdown
Member

Thanks for the contribution. We'll wait for the CLA signing process to progress next, it may not move very quickly, just for your awareness.

@Aman6744

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution. We'll wait for the CLA signing process to progress next, it may not move very quickly, just for your awareness.

Thanks @chenjian2664
My cla is acknowledged today. How do we re-trigger the failed check?

@electrum

Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Apr 28, 2026
@cla-bot

cla-bot Bot commented Apr 28, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@electrum
electrum merged commit 1ddb0f9 into trinodb:master Apr 28, 2026
18 checks passed
@github-actions github-actions Bot added this to the 481 milestone Apr 28, 2026
@ebyhr ebyhr mentioned this pull request Apr 27, 2026
@Aman6744
Aman6744 deleted the fix/java25-docs branch May 2, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Documentation references Java 24 instead of Java 25 after JDK upgrade in release 479,480

4 participants