Skip to content

chore/fair-queueing-ck-spike#4352

Merged
1stvamp merged 8 commits into
chore/fair-queueing-spikefrom
chore/fair-queueing-ck-spike
Jul 23, 2026
Merged

chore/fair-queueing-ck-spike#4352
1stvamp merged 8 commits into
chore/fair-queueing-spikefrom
chore/fair-queueing-ck-spike

Conversation

@1stvamp

@1stvamp 1stvamp commented Jul 23, 2026

Copy link
Copy Markdown
Member

1stvamp added 8 commits July 23, 2026 05:38
Baseline reproduces production age-order starvation; a fair discipline fixes
it end-to-end through the real CK-dequeue Lua and concurrency gating.
At the concurrency-key grain the production age-order baseline starves keys
(worst contention share 0.000 on skew); SFQ/stride/DRR fix it driving the real
CK-dequeue Lua via ckIndex rescoring. Confirms the base-queue spike's ranking at
the real #2617 seam.
Blind two-model review found the ckSkew/ckBalanced baseline starvation was a
Redis lexicographic tie-break on equal enqueue timestamps, not age order.
Redesigned scenarios so the backlog key keeps a genuinely old head and other
keys arrive via poisson, so the baseline now exercises real age-order
starvation (ckSkew baseline 0.187, worst key waits 1321ms; SFQ cuts it to 16ms).
FINDINGS corrected: lead with per-key wait (contention share is volume-confounded
for low-volume keys), and add the key fidelity limit the review surfaced: the
harness serves one key per Lua call, while production batches and re-scores a
served key mid-call, so this proves the ordering fix only at maxCount=1 and a
production fix must advance per-key state inside the batched Lua. Softened
'viable' to 'worth a design spike'.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2133d82e-c53f-4063-a445-7a03b9e51a7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fair-queueing-ck-spike

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b9a6557

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@1stvamp
1stvamp merged commit b9a6557 into chore/fair-queueing-spike Jul 23, 2026
28 of 30 checks passed
@1stvamp
1stvamp deleted the chore/fair-queueing-ck-spike branch July 23, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant