chore/fair-queueing-spike#4351
Conversation
Design doc for a throwaway spike that ranks four fair-queueing methods (SFQ virtual-time tags, hierarchical DRR, CoDel staleness monitor, stride/lottery baseline) against the current FairQueueSelectionStrategy. Drives the real RunQueue behind its selection-strategy interface on a testcontainers Redis and ranks on fairness, tail latency, and cost. Addresses the sub-environment fairness gap in #2617.
Adds the scenario definitions and the selector-by-scenario bench, plus the metric rework the real data forced: because the sim drains every run, final throughput share is fixed by the workload, so fairness is measured as contention-window share (share while >=2 tenants have work) and per-tenant wait. Reader now reads head ages from the master-queue scores in one call. Results JSON captured under results/.
Responds to a multi-model review of the spike: - Runs every scenario over multiple seeds and reports the min..max spread; the baseline's fairness turns out seed-variant while the virtual-time schemes are seed-stable. An earlier single-seed claim that DRR dipped below baseline did not survive multiple seeds. - Adds a poisson trickle scenario so queue heads actually age (the earlier suite only used bulk arrival, which left the baseline's age bias and the CoDel wrapper both inert). - Adds a codel-baseline variant. The data shows the CoDel wrapper is a no-op under bulk arrival and slightly harmful under trickle arrival, so FINDINGS no longer recommends shipping it. - Fixes a vacuous smoke-test assertion (renamed metric field) and switches the metric to contention-window share plus per-tenant wait, since final throughput share is fixed by the workload and cannot distinguish selectors. - Rewrites FINDINGS to match, including the corrected CoDel explanation.
Second review round (blind multi-model) found real issues: - Contention metric counted poisson tenants as contending before their runs arrived, so trickle numbers measured arrival shape not fairness; it now only counts a tenant once it has arrived, unserved work. - SFQ/stride floor was not monotonic, so a returning idle tenant could monopolise service (the CFS min_vruntime guarantee the comments claimed but did not implement). Floor is now monotonic non-decreasing. - Dropped the misleading EEVDF eligibility term from SFQ (it never changed the ordering); it is plain start-time WFQ. - FINDINGS corrected throughout: the DRR shortfall is a batch-drain measurement artifact (and virtual-time clusters queues at ties too, so the earlier explanation was wrong); worstWaitP99 is not an anti-staleness signal; the baseline age bias is not exercised here; cost was not rigorously measured; CoDel actively hurts under trickle arrival. Added the definitional-advantage and age-bias caveats up front. - Persist rough cost proxies to results JSON; note flushdb scope; drop dead seed field from scenarios.
Baseline reproduces production age-order starvation; a fair discipline fixes it end-to-end through the real CK-dequeue Lua and concurrency gating.
At the concurrency-key grain the production age-order baseline starves keys (worst contention share 0.000 on skew); SFQ/stride/DRR fix it driving the real CK-dequeue Lua via ckIndex rescoring. Confirms the base-queue spike's ranking at the real #2617 seam.
Blind two-model review found the ckSkew/ckBalanced baseline starvation was a Redis lexicographic tie-break on equal enqueue timestamps, not age order. Redesigned scenarios so the backlog key keeps a genuinely old head and other keys arrive via poisson, so the baseline now exercises real age-order starvation (ckSkew baseline 0.187, worst key waits 1321ms; SFQ cuts it to 16ms). FINDINGS corrected: lead with per-key wait (contention share is volume-confounded for low-volume keys), and add the key fidelity limit the review surfaced: the harness serves one key per Lua call, while production batches and re-scores a served key mid-call, so this proves the ordering fix only at maxCount=1 and a production fix must advance per-key state inside the batched Lua. Softened 'viable' to 'worth a design spike'.
The plan of record ships concurrency caps (per-task total, per-key limit) and leaves the fair-selection scoring untouched, the opposite lever from the earlier spike's SFQ recommendation. Adds the reconciliation design and the queueing-theory research grounding it (WFQ/SFQ wait bounds, concurrency-cap fairness limits, CoDel scope, real multi-tenant systems, Little's law).
Runs the plan's concurrency caps (per-key limit via the real per-queue gate, total cap via a driver group gate) head-to-head with SFQ/DRR through the real CK-dequeue Lua. Per-key caps fix a starved key's wait when one key floods (eligibility-aware dequeue) but fail when a tenant shards its backlog across many keys (the sybil split), and are not work-conserving; a total cap only lowers the ceiling and worsens cross-key wait; scheduling fixes every case including sybil and stays work-conserving. Adds a makespan work-conservation metric.
Blind two-model review (a third stalled). Folds in: consistent relative-ranking register instead of proven/disproven; reframes the total cap as a capacity- confounded cross-task knob, not a cross-key fairness failure; leads the sybil result with the mechanism (unbounded per-key sum) plus the real Lua's 3-wide scan window (ZRANGEBYSCORE ... LIMIT 0, maxCount*3), which governs why per-key caps work with one heavy key and give no wait improvement once a tenant shards (sybil bumped to 20 attacker keys, now flat vs baseline). Adds the shipped combined total+per-key config and a fully-layered total+per-key+sfq treatment. Marks the caps-first sequencing as interpretation, not measured. Corrects the makespan doc (last dequeue, arrival-confounded off ckHeavyIdle), defines worstWait, notes the contention-share seed spread, and comments the speculative order() coupling.
Measures the claim the caps bench left argued-not-measured: the per-task total cap's real purpose is cross-TASK isolation, not cross-key. Two keyless tasks share one env; capping the heavy task (its real per-queue concurrency gate, which for a keyless task equals its total cap) cuts the light task's wait 475 to 2 under the production FairQueueSelectionStrategy, versus failing at the cross-key grain. Still not work-conserving (makespan 2039 to 3039); SFQ protects the light task too and stays work-conserving. Adds a perQueueCap hook to the base-queue driver.
|
WalkthroughAdds an isolated fair-queueing spike with design documentation, deterministic workload generation, Redis-backed RunQueue simulation, fairness and latency metrics, and tests. Implements SFQ, DRR, stride, and CoDel-wrapped selectors alongside the baseline strategy. Adds concurrency-key rescoring and cap-comparison experiments, benchmark execution across multiple scenarios and seeds, persists JSON results, and documents findings, caveats, and follow-on work. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
internal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.ts (1)
76-109: 🚀 Performance & Scalability | 🔵 Trivial | 🏗️ Heavy liftCodelWrapper doubles the active-queue Redis read on every distribute call.
Every base strategy (
DrrStrategy/SfqStrategy/StrideStrategy) already callsreadActiveQueuesinternally inside its owndistributeFairQueuesFromParentQueue.CodelWrappercalls it again via its ownreaderin the samePromise.all, doubling the Redis round trip for every selection round in the benchmark. Because the two reads execute independently,baseOrderandgroupOfQueue/minHeadByGroupcan reflect slightly different Redis snapshots — any queue present in one but not the other silently falls to the "cold" partition, which is safe but adds noise to a harness whose whole purpose is precise latency/fairness comparison.Since this doubles a real dependency call on a hot benchmark path (and can skew wrapped-vs-unwrapped latency comparisons), consider threading a single active-queue read through to the base strategy rather than having both the wrapper and the base independently query Redis.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9dd13184-27d4-4026-a6bf-301696e9453b
📒 Files selected for processing (29)
docs/superpowers/plans/2026-07-23-fair-queueing-spike.mddocs/superpowers/specs/2026-07-23-fair-queueing-spike-design.mdinternal-packages/run-engine/src/run-queue/fairness-spike/FINDINGS.mdinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/results/adversarialSkew.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/results/balanced.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/results/burst.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/results/longHold.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/results/trickleStale.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/results/weighted.jsoninternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (18)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: runops-guard / runops-guard
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: typecheck / typecheck
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/support.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.tsinternal-packages/run-engine/src/run-queue/fairness-spike/types.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/metrics.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.ts
🪛 LanguageTool
docs/superpowers/specs/2026-07-23-fair-queueing-spike-design.md
[grammar] ~7-~7: Ensure spelling is correct
Context: ...s a ranking table plus a short findings writeup. Background: the current RunQueue does en...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~35-~35: Ensure spelling is correct
Context: ...rency slot for a sampled duration, then acks. The driver records every dequeue event...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~98-~98: Ensure spelling is correct
Context: ...tions, not real long-running runs. - No webapp wiring. ## Deliverable The ranking ta...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
docs/superpowers/plans/2026-07-23-fair-queueing-spike.md
[grammar] ~203-~203: Ensure spelling is correct
Context: ...eue). 2. For each active queue compute startTag = max(virtualClock.get(groupId) ?? systemVirtualTime, systemVirtualTime)`. 3. Eligibility (EEVDF-style): a queue ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~226-~226: Ensure spelling is correct
Context: ...mber>, activeOrder: GroupId[]` (round-robin cursor). Selection: 1. Read active queues; ensur...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~294-~294: Ensure spelling is correct
Context: ...runCount 100, all enqueued at t=0 after 500ms idle, envLimit 6, hold 20. - longHold...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~299-~299: Ensure spelling is correct
Context: ...sults/.json` for the findings writeup. - [ ] Step 2: Run the full matrix ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.23.0)
docs/superpowers/plans/2026-07-23-fair-queueing-spike.md
[warning] 267-267: Spaces inside code span elements
(MD038, no-space-in-code)
🪛 OpenGrep (1.25.0)
internal-packages/run-engine/src/run-queue/fairness-spike/results/weighted.json
[ERROR] 151-151: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike/results/trickleStale.json
[ERROR] 19-19: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 22-22: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 24-24: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 58-58: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 173-173: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 275-275: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 334-334: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 337-337: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 339-339: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 384-384: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike/results/adversarialSkew.json
[ERROR] 21-21: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 501-501: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
🔇 Additional comments (24)
internal-packages/run-engine/src/run-queue/fairness-spike/types.ts (1)
17-102: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/harness/workload.ts (1)
1-112: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/support.ts (1)
1-32: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/workload.test.ts (1)
1-49: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/harness/scenarios.ts (1)
1-71: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/fairnessSpike.bench.test.ts (1)
1-189: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/adversarialSkew.json (1)
1-594: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/balanced.json (1)
1-460: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/burst.json (1)
1-594: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/longHold.json (1)
1-460: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/trickleStale.json (1)
1-393: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/results/weighted.json (1)
1-326: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.ts (1)
1-171: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/queueReader.test.ts (1)
1-86: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/driver.smoke.test.ts (1)
1-45: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/strategies/base.ts (1)
1-30: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/strategies/drrStrategy.ts (1)
1-99: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/strategies/sfqStrategy.ts (1)
1-84: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/strategies/strideStrategy.ts (1)
1-72: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/strategies/codelWrapper.ts (1)
1-75: LGTM!Also applies to: 111-114
internal-packages/run-engine/src/run-queue/fairness-spike/tests/codel.test.ts (1)
1-63: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/drr.test.ts (1)
1-56: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/sfq.test.ts (1)
1-48: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike/tests/stride.test.ts (1)
1-42: LGTM!
| - Selectors advance internal state only via the `onServiced` hook, never by editing production Lua. | ||
| - Determinism: every random draw goes through a seeded `seedrandom` instance. No `Date.now()` for ordering decisions inside selectors; the driver owns a logical clock and passes timestamps in. | ||
| - Single Redis shard (`shardCount: 1`). Multi-shard fairness is out of scope. | ||
| - Verify with: `cd internal-packages/run-engine && pnpm run test ./src/run-queue/fairness-spike/<file> --run` (may need `pnpm run build --filter @internal/run-engine` first). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use typecheck as the package correctness gate.
Keep the test command, but replace the suggested build prerequisite with the package’s typecheck command. As per coding guidelines, “For internal packages, use typecheck for verification and never use build as the correctness check.”
Source: Coding guidelines
| Fairness grain is the `concurrencyKey`/groupId, expressed as ordering among the | ||
| sibling queue keys that come back in `EnvQueues.queues`. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Align the documented fairness grain with the implemented experiment.
The design says the benchmark orders concurrency keys, while the implementation groups multiple base queues by tenant ID; the plan also says each tenant has exactly one base queue. This changes what the benchmark’s fairness results prove.
docs/superpowers/specs/2026-07-23-fair-queueing-spike-design.md#L41-L42: describe tenant-level grouping across base queues and state that concurrency-key ordering remains below the selection seam.docs/superpowers/plans/2026-07-23-fair-queueing-spike.md#L27-L36: replace the one-base-queue-per-tenant constraint with the implemented tenant/queueCountmodel.
📍 Affects 2 files
docs/superpowers/specs/2026-07-23-fair-queueing-spike-design.md#L41-L42(this comment)docs/superpowers/plans/2026-07-23-fair-queueing-spike.md#L27-L36
| This is a throwaway spike. It ships nothing and should be deleted before any | ||
| merge to main; it exists to inform a design decision, not to become code. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Resolve the spike’s merge disposition.
This says the spike “should be deleted before any merge to main,” but the PR adds it to a branch targeting main. Remove the spike before merge, or revise this statement only if retaining the benchmark, Testcontainers suite, and generated fixtures is intentional.
| const { counts: windowCounts, windowSize, contended } = contentionCounts(events); | ||
| const sumWindowWeights = [...contended].reduce((a, g) => a + (weights[g] ?? 1), 0); | ||
|
|
||
| const waitsByGroup = new Map<GroupId, number[]>(); | ||
| for (const g of groupIds) waitsByGroup.set(g, []); | ||
| for (const e of events) { | ||
| waitsByGroup.get(e.groupId)?.push(e.dequeueAtMs - e.enqueueAtMs); | ||
| } | ||
|
|
||
| const perGroup: GroupMetrics[] = groupIds.map((g) => { | ||
| const waits = (waitsByGroup.get(g) ?? []).slice().sort((a, b) => a - b); | ||
| const dequeued = waits.length; | ||
| const weight = weights[g] ?? 1; | ||
| const share = total > 0 ? dequeued / total : 0; | ||
|
|
||
| const windowShare = windowSize > 0 ? (windowCounts.get(g) ?? 0) / windowSize : 0; | ||
| const expectedWindowShare = sumWindowWeights > 0 ? weight / sumWindowWeights : 0; | ||
| const contentionShareOverWeight = | ||
| expectedWindowShare > 0 ? windowShare / expectedWindowShare : 0; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Calculate expected weighted service per contention instant.
sumWindowWeights includes every group that contended at any time. With staggered arrivals (A/B contend, then B/C contend), a fair schedule is scored against a three-group denominator and appears unfair. Accumulate each active group’s expected allocation during every contention dequeue, then divide observed dequeues by that per-group expectation.
Add a staggered-overlap regression case to metrics.test.ts.
Proposed direction
- const sumWindowWeights = [...contended].reduce((a, g) => a + (weights[g] ?? 1), 0);
+ // For every contention dequeue, add:
+ // expected[g] += weight[g] / sum(weights for groups with work now)
- const windowShare = windowSize > 0 ? (windowCounts.get(g) ?? 0) / windowSize : 0;
- const expectedWindowShare = sumWindowWeights > 0 ? weight / sumWindowWeights : 0;
- const contentionShareOverWeight =
- expectedWindowShare > 0 ? windowShare / expectedWindowShare : 0;
+ const expected = expectedCounts.get(g) ?? 0;
+ const contentionShareOverWeight =
+ expected > 0 ? (windowCounts.get(g) ?? 0) / expected : 0;|
Closing the spike draft; the work is consolidated on the single branch chore/fair-queueing-spike. Moving to an implementation plan for the recommended strategy. |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.ts (1)
3-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winColocate this test with
harness/ckDriver.ts.Move it to the driver’s directory (for example,
harness/ckDriver.smoke.test.ts). As per coding guidelines, “Place test files next to the source files they test.”Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0d8cc4d1-fc58-4cf3-9263-58455af3892f
📒 Files selected for processing (28)
docs/superpowers/plans/2026-07-23-fair-queueing-ck-spike.mddocs/superpowers/specs/2026-07-23-fair-queueing-ck-spike-design.mddocs/superpowers/specs/2026-07-23-fairness-caps-vs-scheduling-design.mdinternal-packages/run-engine/src/run-queue/fairness-spike-ck/CAPS_FINDINGS.mdinternal-packages/run-engine/src/run-queue/fairness-spike-ck/FINDINGS.mdinternal-packages/run-engine/src/run-queue/fairness-spike-ck/RESEARCH.mdinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckHeavyIdle.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSkew.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSybil.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckTrickle.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckBalanced.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckSkew.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckTrickle.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/results/xtask-crossTaskSkew.jsoninternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.tsinternal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- internal-packages/run-engine/src/run-queue/fairness-spike/harness/metrics.ts
- internal-packages/run-engine/src/run-queue/fairness-spike/harness/driver.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (18)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (11, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 12)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
- GitHub Check: runops-guard / runops-guard
- GitHub Check: internal / 🧪 Unit Tests: Internal
- GitHub Check: code-quality / code-quality
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
**/*.{ts,tsx}: Prefer static imports over dynamicimport(); use dynamic imports only for unresolvable circular dependencies, genuine performance code splitting, or conditional runtime loading.
Import Trigger.dev tasks from@trigger.dev/sdk; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs while writing code using approved namespaces; mark lines with//@Crumbsor blocks with `// `#region` `@crumbs, and strip them before merging.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
**/*.{test,spec}.{ts,tsx}: Use Vitest exclusively and never mock dependencies; use Testcontainers for integration dependencies.
Place test files next to the source files they test.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
internal-packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
For internal packages, use
typecheckfor verification and never usebuildas the correctness check.
Files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
🧠 Learnings (11)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckDriver.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckDriver.smoke.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.tsinternal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.ts
🪛 LanguageTool
docs/superpowers/specs/2026-07-23-fair-queueing-ck-spike-design.md
[grammar] ~68-~68: Ensure spelling is correct
Context: ...atrix, multi-seed. - FINDINGS.md: the writeup. ## Scenarios (seeded, multi-seed) - ckSkew...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/RESEARCH.md
[grammar] ~44-~44: Ensure spelling is correct
Context: ...cuts light tenant L's wait to near-zero iff BOTH: 1. Slot availability: sum of cap...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~90-~90: The double modal “needs bounded” is nonstandard (only accepted in certain dialects). Consider “to be bounded”.
Context: ...n one tenant could use all K) and needs bounded, pre-known tenant cardinality. ## Prod...
(NEEDS_FIXED)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/FINDINGS.md
[style] ~9-~9: Consider using a shorter alternative to avoid wordiness.
Context: ...e same. A CoDel wrapper on the baseline makes it worse. This was measured by driving the real ...
(MADE_IT_JJR)
[grammar] ~85-~85: Ensure spelling is correct
Context: ...e key per Lua call (maxCount = 1) and rescores ckIndex before each call. Production ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.23.0)
docs/superpowers/specs/2026-07-23-fair-queueing-ck-spike-design.md
[warning] 6-6: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🪛 OpenGrep (1.25.0)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckSkew.json
[ERROR] 45-45: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 78-78: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 90-90: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 160-160: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 230-230: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 300-300: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 428-428: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckTrickle.json
[ERROR] 18-18: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 22-22: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 23-23: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 54-54: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 81-81: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 128-128: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 177-177: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 225-225: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 263-263: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 264-264: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckBalanced.json
[ERROR] 18-18: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 19-19: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 92-92: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 126-126: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 185-185: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 210-210: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 244-244: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 269-269: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 303-303: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 313-313: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 351-351: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckTrickle.json
[ERROR] 37-37: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 68-68: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 138-138: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 153-153: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 184-184: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 196-196: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 211-211: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 242-242: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 260-260: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 279-279: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 336-336: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 384-384: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/xtask-crossTaskSkew.json
[ERROR] 26-26: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSkew.json
[ERROR] 59-59: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 92-92: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 185-185: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 190-190: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 219-219: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 220-220: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 241-241: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 252-252: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 265-265: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 270-270: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 299-299: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 300-300: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 321-321: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 332-332: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 359-359: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 439-439: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 519-519: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 528-528: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSybil.json
[ERROR] 142-142: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 219-219: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 1326-1326: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 1444-1444: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 1466-1466: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
[ERROR] 1978-1978: Possible credit card number (PAN) detected in source code. Credit card numbers should never be hardcoded or stored in source files. Use a secrets manager or tokenization service instead.
(coderabbit.pii.credit-card-number)
🔇 Additional comments (24)
internal-packages/run-engine/src/run-queue/fairness-spike-ck/harness/ckScenarios.ts (1)
1-53: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/ckFairnessSpike.bench.test.ts (1)
1-107: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckBalanced.json (1)
1-370: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckSkew.json (1)
1-437: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/ckTrickle.json (1)
1-303: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/FINDINGS.md (1)
1-123: LGTM!docs/superpowers/plans/2026-07-23-fair-queueing-ck-spike.md (1)
1-69: LGTM!docs/superpowers/specs/2026-07-23-fair-queueing-ck-spike-design.md (1)
1-91: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/ckReader.ts (1)
1-44: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/ckRescorer.ts (1)
1-29: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/disciplines.ts (1)
1-40: LGTM!Also applies to: 42-69, 123-149, 151-201
internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckReader.test.ts (1)
1-81: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/ckRescorer.test.ts (1)
1-64: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/tests/disciplines.test.ts (1)
1-85: LGTM!docs/superpowers/specs/2026-07-23-fairness-caps-vs-scheduling-design.md (1)
1-65: LGTM!Also applies to: 77-113, 122-122
internal-packages/run-engine/src/run-queue/fairness-spike-ck/CAPS_FINDINGS.md (1)
1-198: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/RESEARCH.md (1)
1-134: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/capsFairness.bench.test.ts (1)
1-239: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/crossTaskCaps.bench.test.ts (1)
1-194: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckHeavyIdle.json (1)
1-305: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSkew.json (1)
1-661: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckSybil.json (1)
1-2085: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/caps-ckTrickle.json (1)
1-483: LGTM!internal-packages/run-engine/src/run-queue/fairness-spike-ck/results/xtask-crossTaskSkew.json (1)
1-192: LGTM!
| - Per-key cap: a discipline marks any CK variant whose in-flight >= its per-key | ||
| cap as INELIGIBLE. The driver writes ineligible variants a beyond-window | ||
| `ckIndex` score so the real Lua's `ZRANGEBYSCORE -inf now` skips them, exactly | ||
| as the real per-key gate would. Among eligible variants, keep baseline age | ||
| order (or an inner scheduler for the layered discipline). | ||
| - Total cap: the driver refuses to dequeue when total in-flight (holding.length, | ||
| = group SCARD for one base queue) >= the total cap, modelling the group gate. | ||
|
|
||
| This is faithful to the plan's eligibility-aware semantics; the fidelity gap is | ||
| the same `maxCount = 1` one the CK spike already documents (production dequeues in | ||
| batches; a real per-key/total gate lives inside the batched Lua). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Design doc's harness/scope description is stale vs. what was actually built.
Two spots in this plan no longer match the implementation delivered in this same cohort:
- Lines 66-70 describe the per-key cap as simulated via driver-side rescoring ("a discipline marks any CK variant... INELIGIBLE. The driver writes ineligible variants a beyond-window
ckIndexscore"). ButCAPS_FINDINGS.md's fidelity section says the opposite was actually implemented: the REAL Lua gate. updateQueueConcurrencyLimits sets the base queue's concurrencyLimit; the CK-dequeue Lua caps each ck variant's in-flight at it and skips an at-limit variant (oldest-eligible-first, true age order, no rescore). This matchesckDriver.ts's actual call toqueue.updateQueueConcurrencyLimits(env, BASE_QUEUE, config.perKeyCap)— no rescore-based ineligibility marking is used. - Lines 114-121 list a cross-task harness as explicitly "Not building" ("A cross-task harness is noted as future work"). But
crossTaskCaps.bench.test.tsis exactly that harness, andCAPS_FINDINGS.mddocuments it as already measured: Total cap (Phase 1) at the cross-TASK grain: this IS its job, and it works. Measured in a separate multi-base-queue bench (crossTaskCaps.bench.test.ts).
Since this design doc anchors the PR stack's decision narrative, readers relying on it (including reviewers of the sibling PRs #4352/#4353) would get a false picture of what was modeled and what's out of scope. Worth reconciling the plan doc with the findings before this stack merges/gets deleted.
Also applies to: 114-121
| order(active: ActiveCk[]): string[] { | ||
| const activeKeys = new Set(active.map((a) => a.concurrencyKey)); | ||
| for (const k of activeKeys) if (!this.ring.includes(k)) this.ring.push(k); | ||
| this.ring = this.ring.filter((k) => activeKeys.has(k)); | ||
| if (this.ring.length === 0) return []; | ||
| if (this.cursor >= this.ring.length) this.cursor = 0; | ||
|
|
||
| let winner = this.ring[this.cursor]; | ||
| for (let steps = 0; steps < this.ring.length; steps++) { | ||
| const k = this.ring[this.cursor]; | ||
| if ((this.deficit.get(k) ?? 0) < 1) { | ||
| this.deficit.set(k, (this.deficit.get(k) ?? 0) + this.quantum); | ||
| } | ||
| if ((this.deficit.get(k) ?? 0) >= 1) { | ||
| winner = k; | ||
| break; | ||
| } | ||
| this.cursor = (this.cursor + 1) % this.ring.length; | ||
| } | ||
|
|
||
| const rank = new Map<string, number>(); | ||
| rank.set(winner, -1); | ||
| for (let i = 0; i < this.ring.length; i++) { | ||
| const k = this.ring[(this.cursor + i) % this.ring.length]; | ||
| if (!rank.has(k)) rank.set(k, i); | ||
| } | ||
| return byPriority(active, (ck) => rank.get(ck) ?? this.ring.length); | ||
| } | ||
| onServiced(ck: string): void { | ||
| this.deficit.set(ck, (this.deficit.get(ck) ?? 0) - 1); | ||
| if ((this.deficit.get(ck) ?? 0) < 1) { | ||
| const idx = this.ring.indexOf(ck); | ||
| if (idx !== -1) this.cursor = (idx + 1) % this.ring.length; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
DRR cursor becomes stale after ring membership changes.
this.ring.filter(...) reindexes the array, but this.cursor is a plain numeric index that isn't remapped. If a key before the cursor position drops out of the active set (e.g. its queue empties briefly), the array shifts left while cursor stays the same number — so ring[cursor] now silently refers to a different key. Example: ring=[a,b,c,d], cursor=1 (→"b"); "a" goes inactive → ring=[b,c,d]; cursor is still 1, but ring[1] is now "c", not "b". The out-of-bounds guard (if (this.cursor >= this.ring.length) this.cursor = 0;) doesn't catch this because the index is still in range — it's just pointing at the wrong key.
This corrupts DRR's round-robin fairness precisely under the CK-churn conditions the ckTrickle scenario is meant to exercise, which undermines the validity of DRR's benchmark results. None of the current tests exercise ring-membership churn across calls, so this would go unnoticed.
🐛 Proposed fix: track cursor by key identity instead of index
export class DrrCk implements CkDiscipline {
readonly name = "drr";
readonly rescore = true;
private deficit = new Map<string, number>();
private ring: string[] = [];
- private cursor = 0;
+ private cursorKey: string | null = null;
private readonly quantum: number;
constructor(quantum = 1) {
this.quantum = quantum;
}
reset(): void {
this.deficit = new Map();
this.ring = [];
- this.cursor = 0;
+ this.cursorKey = null;
}
order(active: ActiveCk[]): string[] {
const activeKeys = new Set(active.map((a) => a.concurrencyKey));
for (const k of activeKeys) if (!this.ring.includes(k)) this.ring.push(k);
this.ring = this.ring.filter((k) => activeKeys.has(k));
if (this.ring.length === 0) return [];
- if (this.cursor >= this.ring.length) this.cursor = 0;
+ let cursor = this.cursorKey !== null ? this.ring.indexOf(this.cursorKey) : -1;
+ if (cursor === -1) cursor = 0;
- let winner = this.ring[this.cursor];
+ let winner = this.ring[cursor];
for (let steps = 0; steps < this.ring.length; steps++) {
- const k = this.ring[this.cursor];
+ const k = this.ring[cursor];
if ((this.deficit.get(k) ?? 0) < 1) {
this.deficit.set(k, (this.deficit.get(k) ?? 0) + this.quantum);
}
if ((this.deficit.get(k) ?? 0) >= 1) {
winner = k;
break;
}
- this.cursor = (this.cursor + 1) % this.ring.length;
+ cursor = (cursor + 1) % this.ring.length;
}
+ this.cursorKey = this.ring[cursor];
const rank = new Map<string, number>();
rank.set(winner, -1);
for (let i = 0; i < this.ring.length; i++) {
- const k = this.ring[(this.cursor + i) % this.ring.length];
+ const k = this.ring[(cursor + i) % this.ring.length];
if (!rank.has(k)) rank.set(k, i);
}
return byPriority(active, (ck) => rank.get(ck) ?? this.ring.length);
}
onServiced(ck: string): void {
this.deficit.set(ck, (this.deficit.get(ck) ?? 0) - 1);
if ((this.deficit.get(ck) ?? 0) < 1) {
const idx = this.ring.indexOf(ck);
- if (idx !== -1) this.cursor = (idx + 1) % this.ring.length;
+ if (idx !== -1) this.cursorKey = this.ring[(idx + 1) % this.ring.length];
}
}
}Also worth adding a regression test in disciplines.test.ts that removes/re-adds a key across order() calls to lock in correct cursor behavior.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| order(active: ActiveCk[]): string[] { | |
| const activeKeys = new Set(active.map((a) => a.concurrencyKey)); | |
| for (const k of activeKeys) if (!this.ring.includes(k)) this.ring.push(k); | |
| this.ring = this.ring.filter((k) => activeKeys.has(k)); | |
| if (this.ring.length === 0) return []; | |
| if (this.cursor >= this.ring.length) this.cursor = 0; | |
| let winner = this.ring[this.cursor]; | |
| for (let steps = 0; steps < this.ring.length; steps++) { | |
| const k = this.ring[this.cursor]; | |
| if ((this.deficit.get(k) ?? 0) < 1) { | |
| this.deficit.set(k, (this.deficit.get(k) ?? 0) + this.quantum); | |
| } | |
| if ((this.deficit.get(k) ?? 0) >= 1) { | |
| winner = k; | |
| break; | |
| } | |
| this.cursor = (this.cursor + 1) % this.ring.length; | |
| } | |
| const rank = new Map<string, number>(); | |
| rank.set(winner, -1); | |
| for (let i = 0; i < this.ring.length; i++) { | |
| const k = this.ring[(this.cursor + i) % this.ring.length]; | |
| if (!rank.has(k)) rank.set(k, i); | |
| } | |
| return byPriority(active, (ck) => rank.get(ck) ?? this.ring.length); | |
| } | |
| onServiced(ck: string): void { | |
| this.deficit.set(ck, (this.deficit.get(ck) ?? 0) - 1); | |
| if ((this.deficit.get(ck) ?? 0) < 1) { | |
| const idx = this.ring.indexOf(ck); | |
| if (idx !== -1) this.cursor = (idx + 1) % this.ring.length; | |
| } | |
| } | |
| } | |
| order(active: ActiveCk[]): string[] { | |
| const activeKeys = new Set(active.map((a) => a.concurrencyKey)); | |
| for (const k of activeKeys) if (!this.ring.includes(k)) this.ring.push(k); | |
| this.ring = this.ring.filter((k) => activeKeys.has(k)); | |
| if (this.ring.length === 0) return []; | |
| let cursor = this.cursorKey !== null ? this.ring.indexOf(this.cursorKey) : -1; | |
| if (cursor === -1) cursor = 0; | |
| let winner = this.ring[cursor]; | |
| for (let steps = 0; steps < this.ring.length; steps++) { | |
| const k = this.ring[cursor]; | |
| if ((this.deficit.get(k) ?? 0) < 1) { | |
| this.deficit.set(k, (this.deficit.get(k) ?? 0) + this.quantum); | |
| } | |
| if ((this.deficit.get(k) ?? 0) >= 1) { | |
| winner = k; | |
| break; | |
| } | |
| cursor = (cursor + 1) % this.ring.length; | |
| } | |
| this.cursorKey = this.ring[cursor]; | |
| const rank = new Map<string, number>(); | |
| rank.set(winner, -1); | |
| for (let i = 0; i < this.ring.length; i++) { | |
| const k = this.ring[(cursor + i) % this.ring.length]; | |
| if (!rank.has(k)) rank.set(k, i); | |
| } | |
| return byPriority(active, (ck) => rank.get(ck) ?? this.ring.length); | |
| } | |
| onServiced(ck: string): void { | |
| this.deficit.set(ck, (this.deficit.get(ck) ?? 0) - 1); | |
| if ((this.deficit.get(ck) ?? 0) < 1) { | |
| const idx = this.ring.indexOf(ck); | |
| if (idx !== -1) this.cursorKey = this.ring[(idx + 1) % this.ring.length]; | |
| } | |
| } |
| const admin = createRedisClient(config.redis); | ||
| await admin.flushdb(); |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win
Do not flush the entire configured Redis database.
FLUSHDB ignores keyPrefix, so invoking this harness with a shared Redis database deletes unrelated keys. Delete only this scenario’s prefixed keys, or require an isolated test database.
| // one heavy concurrency key with a big backlog, three light keys | ||
| const workload = buildWorkload({ | ||
| seed: "ck-smoke", | ||
| envConcurrencyLimit: 3, | ||
| tenants: [ | ||
| { tenantId: "heavy", runCount: 90, holdMsMean: 25 }, | ||
| { tenantId: "light-1", runCount: 10, holdMsMean: 25 }, | ||
| { tenantId: "light-2", runCount: 10, holdMsMean: 25 }, | ||
| { tenantId: "light-3", runCount: 10, holdMsMean: 25 }, | ||
| ], |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make the light keys arrive after the heavy backlog.
All tenants currently enqueue at logical time zero, so the baseline result is driven by Redis’s lexicographic tie-break (heavy before light-*), not oldest-head ordering. Give the light tenants deterministic Poisson arrivals, as in CK_SCENARIOS, before asserting this is an age-order fidelity test.
This is part 1 of 3 in a stack made with GitButler: