Skip to content

fix(webapp): billing alert preview uses current limit instead of stale saved amount #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claude wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −3
Draft

fix(webapp): billing alert preview uses current limit instead of stale saved amount #4338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/billing-alert-preview-current-limit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Raising your billing limit now updates the alert threshold preview amounts right away, instead of showing figures based on the previous limit until you save your alerts again.
3 changes: 0 additions & 3 deletions apps/webapp/app/components/billing/billingAlertsFormat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,6 @@ export function getAlertPreviewLimitCents(
planLimitCents: number
): number {
const amountCents = getSavedAlertAmountCents(alerts);
if (amountCents > 0 && percentageAlertLevelsToUiThresholds(alerts.alertLevels).length > 0) {
return amountCents;
}
if (percentageAlertAmountMatches(amountCents, effectiveLimitCents, planLimitCents)) {
return amountCents;
}
Expand Down
12 changes: 12 additions & 0 deletions apps/webapp/test/billingAlertsFormat.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,18 @@ describe("billingAlertsFormat", () => {
).toBe(10_000);
});

it("previews percentage alerts against the current limit after it is raised", () => {
// Alerts were saved against an old $30 limit; the customer has since raised
// it to $300. The preview should follow the current limit, not the snapshot.
expect(
getAlertPreviewLimitCents(
{ amount: 30, emails: [], alertLevels: [0.75, 0.9] },
30_000,
10_000
)
).toBe(30_000);
});

it("normalizes legacy API alerts with dollar amount field and whole percents", () => {
expect(
normalizeBillingAlertsFromApi(
Expand Down