Skip to content

fix: run npm release jobs on ubuntu-latest#4201

Merged
carderne merged 2 commits into
mainfrom
fix/npm-release-runner
Jul 9, 2026
Merged

fix: run npm release jobs on ubuntu-latest#4201
carderne merged 2 commits into
mainfrom
fix/npm-release-runner

Conversation

@carderne

@carderne carderne commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Failed trying to run trust npm publish on warp runner:
https://github.com/triggerdotdev/trigger.dev/actions/runs/29016820615/job/86113758922

@changeset-bot

changeset-bot Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 568714e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 64c46977-f546-44f3-ad9f-19fcfe26ff41

📥 Commits

Reviewing files that changed from the base of the PR and between 7f2ae86 and 568714e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/release.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: code-quality / code-quality
  • GitHub Check: audit

Walkthrough

This change updates .github/workflows/release.yml so the show-release-summary, release, and prerelease jobs now run on ubuntu-latest instead of warp-ubuntu-latest-x64 variants. No other workflow conditions, steps, or settings are changed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required template sections and only mentions the warp-runner failure. Add Closes #issue, checklist, testing steps, changelog, and screenshots sections per the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: moving npm release jobs from warp runners to ubuntu-latest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/npm-release-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne carderne force-pushed the fix/npm-release-runner branch from 9c0aee5 to 0096e84 Compare July 9, 2026 12:31
@carderne carderne marked this pull request as ready for review July 9, 2026 12:31
@carderne carderne enabled auto-merge (squash) July 9, 2026 12:32
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@carderne carderne force-pushed the fix/npm-release-runner branch from 0096e84 to 7f2ae86 Compare July 9, 2026 12:36
coderabbitai[bot]
coderabbitai Bot reviewed Jul 9, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/release.yml (1)

35-35: 🚀 Performance & Scalability | 🔵 Trivial

Runner downgrade may significantly increase build times for release and prerelease.

The release (Line 51) and prerelease (Line 269) jobs previously ran on warp-ubuntu-latest-x64-8x (8-core) and now use ubuntu-latest (2-core). Both jobs perform heavy work: pnpm install, Prisma client generation, full build, and typecheck. On a 2-core runner, these steps will take notably longer, which could slow down the release pipeline and increase queue times.

The other three jobs (show-release-summary, update-release, dispatch-changelog) are lightweight API/echo operations, so the runner downgrade is a non-issue for them.

If build duration becomes a problem, consider using ubuntu-latest-large (or ubuntu-24.04-large) for the two heavy jobs to retain a larger core count while staying on GitHub-hosted runners.

Also applies to: 51-51, 214-214, 256-256, 269-269

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 88b97860-06ad-4694-a26d-dbb4b5c94327

📥 Commits

Reviewing files that changed from the base of the PR and between 0096e84 and 7f2ae86.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: code-quality / code-quality
  • GitHub Check: audit
  • GitHub Check: audit
  • GitHub Check: Zizmor

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@carderne carderne merged commit a3dca98 into main Jul 9, 2026
31 of 32 checks passed
@carderne carderne deleted the fix/npm-release-runner branch July 9, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@ericallam ericallam ericallam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carderne @ericallam