fix(webapp,run-ops-database): keep run-ops batch items co-resident with their batch#4178
Merged
Conversation
On the v4 (RunEngine V2) batch paths, RunEngineBatchTriggerService (api.v2) and the BatchQueue item callback (api.v3), a parentless batch's item runs minted their run-ops residency from a fresh per-org flag read at processing time. A mint-flag flip between batch creation and item processing could then mint an item into a different physical store than its BatchTaskRun row: an FK violation against the run-ops DB's live TaskRun_batchId_fkey (batch on legacy, item on new), or a silent orphan (batch on new, item on legacy). Anchor each item's mint on the batch's own friendlyId (pure id-shape, zero new queries), mirroring the already-safe BatchTriggerV3Service, and anchor the pre-failed-run fallback the same way since it also sets batchId. Consolidate the shared id-generation branch into mintFriendlyIdForKind so every mint path stays in lockstep. Single-DB mode is unchanged: a cuid-shaped batch friendlyId yields a cuid item.
The parity test only read the dedicated run-ops schema and matched model headers with regexes, so it never compared columns against the control-plane schema and could not detect a run-subgraph scalar column that diverged between the two physical schemas. Parse both schemas and assert bidirectional scalar-column parity (type, nullability, array-ness, default) across the run-subgraph models, scoped to those models so an unrelated control-plane edit can't break it, and fail on any unparsed field line so a format change can't silently bypass the check.
The read fan-out gate decides split-mode fan-out purely by the JS object identity of the NEW vs control-plane clients. If a future change made the NEW client alias the control-plane client while both split URLs are set, fan-out would silently disable with no signal, and no test exercised the real wiring from topology selection into the gate. Warn when both run-ops URLs are set but the NEW client is not a distinct instance, and add a glue test feeding the real topology output into the real gate. The gate's enabled value is unchanged.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (24)
|
| Area | Change |
|---|---|
| Mint anchoring | Added mintFriendlyIdForKind and mintAnchoredRunFriendlyId helpers; wired into batchTrigger.server.ts, runEngineHandlers.server.ts, triggerTask.server.ts, batchTriggerV3.server.ts |
| Failed task service | Added optional runFriendlyId override to TriggerFailedTaskRequest, mintFailedRunFriendlyId, call(), and callWithoutTraceEvents |
| Split read gate | Added optional logger parameter and warning to computeRunOpsSplitReadEnabled; db.server.ts now passes logger |
| Schema parity test | Reworked to parse model blocks and scalar fields, added bidirectional parity assertions between control-plane and dedicated schemas |
| Tests | Added/extended unit and regression test suites across all above areas |
Sequence Diagram(s)
sequenceDiagram
participant BatchQueueCallback
participant mintAnchoredRunFriendlyId
participant TriggerTaskService
participant TriggerFailedTaskService
BatchQueueCallback->>mintAnchoredRunFriendlyId: batch.friendlyId, item.options.region
mintAnchoredRunFriendlyId-->>BatchQueueCallback: runFriendlyId
alt success
BatchQueueCallback->>TriggerTaskService: call(runFriendlyId)
else failure or pre-marked error
BatchQueueCallback->>TriggerFailedTaskService: call(runFriendlyId)
end
Related Issues: None referenced in the provided context.
Related PRs: None referenced in the provided context.
Suggested labels: area:webapp, run-engine, tests
Suggested reviewers: None specified in the provided context.
🐰 A batch of runs, each anchored tight,
No flag can flip them mid-flight,
Friendly ids minted true to their store,
Warnings now sound when gates close the door,
Schemas compared, byte for byte.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description has useful context but does not follow the required template sections like Closes #, checklist, Testing, Changelog, and Screenshots. | Reformat the PR description to match the template, including Closes #, checklist items, Testing, Changelog, and Screenshots. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly describes the main change: keeping run-ops batch items co-resident with their batch. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/run-ops-split-hardening
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (4)
internal-packages/run-ops-database/prisma/schema.parity.test.ts (1)
63-68: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a
typealias instead of aninterfaceforFieldInfo.
FieldInfois a plain data shape, so it should be modeled as atype.♻️ Proposed change
-interface FieldInfo { - type: string; - optional: boolean; - array: boolean; - default: string | null; -} +type FieldInfo = { + type: string; + optional: boolean; + array: boolean; + default: string | null; +};As per coding guidelines: "Use types over interfaces for TypeScript".
Sources: Coding guidelines, Learnings
apps/webapp/app/v3/runEngineHandlers.server.ts (1)
841-846: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsolidate the repeated anchored-mint expression.
mintAnchoredRunFriendlyId(friendlyId, (item.options as { region?: string } | undefined)?.region)is duplicated verbatim across four branches in this callback. Functionally harmless today (each call correctly mints a fresh id for a distinct run), but it works against this PR's own goal of consolidating shared minting logic, and increases the risk that a future edit to the anchor/region resolution updates only some branches.Consider hoisting the region extraction and wrapping the mint call in a single local helper at the top of the callback, then calling it at each site.
♻️ Proposed consolidation
async (span) => { const triggerFailedTaskService = new TriggerFailedTaskService({ prisma, engine, replicaPrisma: $replica, }); const itemRegion = (item.options as { region?: string } | undefined)?.region; const anchoredRunFriendlyId = () => mintAnchoredRunFriendlyId(friendlyId, itemRegion); // ... use `anchoredRunFriendlyId()` at each of the 4 call sites instead of // re-deriving the expression inline.Also applies to: 887-891, 948-951, 1032-1035
apps/webapp/test/batchQueueItemResidencyAnchoring.test.ts (1)
105-179: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd coverage for the two remaining anchored branches.
This suite covers the happy path and the "TriggerTaskService returned undefined" failure branch (NEW/LEGACY), but
runEngineHandlers.server.tsalso anchorsrunFriendlyIdin two other branches not exercised here:
- the pre-marked error item branch (
item.options?.__error, around lines 818-862)- the thrown-exception
catchbranch (around lines 973-1046)Since this PR's purpose is closing residency-split gaps across every mint path, these two untested branches leave residual regression risk. The existing
runItem/mock scaffolding makes adding NEW/LEGACY cases for both straightforward.apps/webapp/app/runEngine/services/triggerTask.server.ts (1)
143-157: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider consolidating the mint-kind-resolution branch, not just the id-generation step.
mintFriendlyIdForKindnicely consolidates the id-generation branch, but the surrounding "anchor ? resolveInheritedMintKind : await resolveMintKind(...)" logic (lines 148-154) is duplicated almost verbatim inBatchTriggerV3Service.mintChildFriendlyId(batchTriggerV3.server.ts:356-362). Since this branch determines run residency — the exact contract this PR is hardening — extracting it into a shared helper (e.g., alongsidemintFriendlyIdForKindinmintAnchoredRunFriendlyId.server.ts) would reduce the risk of the two call sites silently diverging later.♻️ Possible consolidation
+// in mintAnchoredRunFriendlyId.server.ts +export async function resolveAndMintFriendlyId( + anchorFriendlyId: string | undefined, + region: string | undefined, + resolveDefaultMintKind: () => Promise<ResidencyKind> +): Promise<string> { + const mintKind = anchorFriendlyId + ? resolveInheritedMintKind(anchorFriendlyId) + : await resolveDefaultMintKind(); + return mintFriendlyIdForKind(mintKind, region); +}
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 9d24131e-6c71-4dca-abbb-2fd923c78b9a
📒 Files selected for processing (17)
.server-changes/fix-batch-item-mint-anchor.md.server-changes/run-ops-split-read-gate-warn.mdapps/webapp/app/db.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (17)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamicimport(); only use dynamic imports when resolving circular dependencies, enabling real code splitting, or conditionally loading a module at runtime.
Always import from@trigger.dev/sdk; never import from@trigger.dev/sdk/v3or use deprecatedclient.defineJob.
In code that imports@trigger.dev/core, use subpath imports only and never import from the package root.
Files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathAlways use
findFirstinstead offindUniquefor Prisma queries.
Files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
apps/webapp/**/*.test.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
Do not import
env.server.tsdirectly or indirectly into test files; instead pass environment-dependent values through options/parameters to make code testable
Files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.ts
apps/webapp/**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
In test files, never import
env.server.ts; pass configuration as options instead.
Files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.ts
**/*.test.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.test.{ts,tsx,js,jsx}: Place test files next to their source files (for example,MyService.ts->MyService.test.ts).
Use Vitest exclusively for tests, and do not mock dependencies; use testcontainers instead.
Files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
apps/webapp/app/v3/services/{cancelTaskRun.server.ts,batchTriggerV3.server.ts}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
When editing
cancelTaskRun.server.tsorbatchTriggerV3.server.ts, only modify the V2 code paths.
Files:
apps/webapp/app/v3/services/batchTriggerV3.server.ts
apps/webapp/app/v3/services/{triggerTask.server.ts,batchTriggerV3.server.ts}
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
Do not add database queries to
triggerTask.server.tsorbatchTriggerV3.server.ts; keep these trigger paths fast and reuse the existingbackgroundWorkerTask.findFirst()query instead.
Files:
apps/webapp/app/v3/services/batchTriggerV3.server.ts
🧠 Learnings (23)
📚 Learning: 2026-05-14T14:54:39.095Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3545
File: .server-changes/agent-view-sessions.md:10-10
Timestamp: 2026-05-14T14:54:39.095Z
Learning: In the `trigger.dev` repository, do not flag inconsistent dot vs slash notation in route/path strings inside `.server-changes/*.md` files. These markdown files are consumed verbatim into the changelog, so the mixed notation (e.g., `resources.orgs.../runs.$runParam/...`) is intentional and should be preserved as-is.
Applied to files:
.server-changes/run-ops-split-read-gate-warn.md.server-changes/fix-batch-item-mint-anchor.md
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-03-29T19:16:28.864Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3291
File: apps/webapp/app/v3/featureFlags.ts:53-65
Timestamp: 2026-03-29T19:16:28.864Z
Learning: When reviewing TypeScript code that uses Zod v3, treat `z.coerce.*()` schemas as their direct Zod type (e.g., `z.coerce.boolean()` returns a `ZodBoolean` with `_def.typeName === "ZodBoolean"`) rather than a `ZodEffects`. Only `.preprocess()`, `.refine()`/`.superRefine()`, and `.transform()` are expected to wrap schemas in `ZodEffects`. Therefore, in reviewers’ logic like `getFlagControlType`, do not flag/unblock failures that require unwrapping `ZodEffects` when the input schema is a `z.coerce.*` schema.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-06-09T16:27:26.195Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3878
File: apps/webapp/app/v3/services/computeTemplateCreation.server.ts:0-0
Timestamp: 2026-06-09T16:27:26.195Z
Learning: When working in triggerdotdev/trigger.dev code related to worker-group/region default resolution (e.g., defaultWorkerInstanceGroupId handling used by getGlobalDefaultWorkerGroup, getDefaultWorkerGroupForProject, and RegionsPresenter), do NOT add org-level featureFlags overrides in only one resolution site. That can cause template creation routing/decisions to diverge from actual run routing. If org-level override of the default region/worker group is required, it must be centralized in getGlobalDefaultWorkerGroup so every resolution path remains aligned.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/app/db.server.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-06-25T18:21:51.905Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4039
File: apps/webapp/app/routes/invite-revoke.tsx:0-0
Timestamp: 2026-06-25T18:21:51.905Z
Learning: During the Zod v4 migration in the triggerdotdev/trigger.dev webapp, ensure any imports from `conform-to/zod` use the Zod-4 subpath: `conform-to/zod/v4` (e.g., `import { parseWithZod } from "conform-to/zod/v4"`). Do not import from the package root `conform-to/zod`, because it is the Zod 3 implementation and may load Zod-3-only symbols (e.g., `ZodBranded`, `ZodEffects`), which can throw at module load (notably with `zod4.4.3`). This should be enforced across `apps/webapp/**/*` where helpers like `parseWithZod` and `conformZodMessage` are used.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-07-03T17:10:21.498Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 4148
File: apps/webapp/app/models/orgMember.server.ts:149-168
Timestamp: 2026-07-03T17:10:21.498Z
Learning: In triggerdotdev/trigger.dev, `User.email` (Prisma schema: `internal-packages/database/prisma/schema.prisma`) currently does NOT use `citext` and does NOT have a `lower(email)` functional unique index. Therefore, do not introduce Prisma queries like `where: { email: { equals: <value>, mode: "insensitive" } }` (or any case-insensitive lookup) against `User.email`, because it can force sequential scans of the `users` table under load. During review, ensure email is normalized (e.g., lowercased/trimmed) before both writes and subsequent lookups, and if true case-insensitive behavior/uniqueness is required, implement it via a separate app-wide migration (e.g., switch to `citext` and/or add a functional unique index with backfill) rather than bolting it onto individual feature PRs.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-05-14T08:21:07.614Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3614
File: apps/webapp/app/v3/mollifier/mollifierGate.server.ts:48-52
Timestamp: 2026-05-14T08:21:07.614Z
Learning: When using Trigger.dev v3 feature flags in the webapp, prefer the existing per-org gating mechanism supported by `flag()` via the `overrides` argument. Pass `Organization.featureFlags` (from `environment.organization.featureFlags`) as the `overrides` value; overrides must take precedence over the global `featureFlag` row. Do not require schema changes or add an `orgId` field to `FlagsOptions` for per-org gating—use the overrides pattern consistently (e.g., in gate flows like `resolveOrgFlag` and any server code that threads `environment.organization.featureFlags` into the gate call).
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/v3/runEngineHandlers.server.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.tsapps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/app/db.server.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsapps/webapp/app/v3/services/batchTriggerV3.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.tsapps/webapp/app/v3/runEngineHandlers.server.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-05-07T12:25:18.271Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3531
File: apps/webapp/test/sentryTraceContext.server.test.ts:9-47
Timestamp: 2026-05-07T12:25:18.271Z
Learning: In the triggerdotdev/trigger.dev webapp test suite, it is acceptable to leave `createInMemoryTracing()` calls that register a global `NodeTracerProvider` without `afterEach`/`afterAll` teardown. Do not flag this as a test-ordering risk when the code follows the established pattern used across webapp tests (e.g., replication service/benchmark/backfiller tests). This is considered safe because `trace.getActiveSpan()` when called outside a `context.with(...)` block reads `AsyncLocalStorage.getStore()` (undefined when no `run()` scope exists), so it falls back to `ROOT_CONTEXT` with no attached span—regardless of which provider is registered.
Applied to files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.ts
📚 Learning: 2026-05-28T20:02:10.647Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3772
File: apps/webapp/test/findOrCreateBackgroundWorker.test.ts:1-1
Timestamp: 2026-05-28T20:02:10.647Z
Learning: In the triggerdotdev/trigger.dev monorepo, for the `apps/webapp` package use the established convention of storing Vitest tests (unit, integration, and e2e) under `apps/webapp/test/` rather than colocating them next to source files. Do not flag files located in `apps/webapp/test/` as violating any rule that says to colocate tests with source.
Applied to files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
apps/webapp/test/runOpsSplitReadGate.glue.test.tsapps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/test/runOpsSplitReadGate.test.tsapps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.tsapps/webapp/test/batchQueueItemResidencyAnchoring.test.tsinternal-packages/run-ops-database/prisma/schema.parity.test.ts
📚 Learning: 2026-05-22T11:50:56.079Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3333
File: apps/webapp/app/runEngine/services/triggerFailedTask.server.ts:76-80
Timestamp: 2026-05-22T11:50:56.079Z
Learning: When reviewing changes related to org-scoped ClickHouse / org reassignment, treat ClickHouse as the source of truth for the affected read paths (e.g., run lists, span detail, logs) with no Postgres fallback. Reassigning an org from one ClickHouse cluster to another must be done by migrating that org’s existing ClickHouse data between clusters first—do not assume it’s sufficient to update only the OrganizationDataStore entry. If any implementation/change would make org reassignment possible, ensure the required migration design/implementation is included (work tracked under Linear TRI-9659, sub-issue of TRI-7994). During the initial rollout of org-scoped ClickHouse (PR `#3333`), no production org has an override configured, so the limitation is not yet reachable in production; don’t introduce production-dependent assumptions that rely on overrides being active.
Applied to files:
apps/webapp/app/runEngine/services/triggerFailedTask.server.test.tsapps/webapp/app/runEngine/services/triggerFailedTask.server.tsapps/webapp/app/runEngine/services/triggerTask.server.tsapps/webapp/app/runEngine/services/batchTrigger.server.ts
📚 Learning: 2026-03-10T17:56:20.938Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3201
File: apps/webapp/app/v3/services/setSeatsAddOn.server.ts:25-29
Timestamp: 2026-03-10T17:56:20.938Z
Learning: Do not implement local userId-to-organizationId authorization checks inside org-scoped service classes (e.g., SetSeatsAddOnService, SetBranchesAddOnService) in the web app. Rely on route-layer authentication (requireUserId(request)) and org membership enforcement via the _app.orgs.$organizationSlug layout route. Any userId/organizationId that reaches these services from org-scoped routes has already been validated. Apply this pattern across all org-scoped services to avoid redundant auth checks and maintain consistency.
Applied to files:
apps/webapp/app/v3/services/batchTriggerV3.server.ts
🪛 ast-grep (0.44.1)
internal-packages/run-ops-database/prisma/schema.parity.test.ts
[warning] 232-234: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(
@relation[^\\n]*\\b${model}\\b|\\b${model}\\b[^\\n]*@relation``
)
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
[warning] 236-236: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(\\s${model}(\\?|\\[\\])?\\s)
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
🪛 OpenGrep (1.23.0)
internal-packages/run-ops-database/prisma/schema.parity.test.ts
[ERROR] 77-77: Dynamic command passed to child_process.exec/execSync. Use child_process.execFile or spawn with an argument array instead.
(coderabbit.command-injection.exec-js)
🔇 Additional comments (21)
internal-packages/run-ops-database/prisma/schema.parity.test.ts (2)
83-146: LGTM!Also applies to: 176-226
59-61: 🎯 Functional CorrectnessNo current
@default(...)values contain//, sostripCommentsdoesn’t truncate any parsed defaults here.> Likely an incorrect or invalid review comment..server-changes/run-ops-split-read-gate-warn.md (1)
1-7: LGTM!apps/webapp/app/v3/runOpsMigration/runOpsSplitReadGate.ts (1)
3-26: LGTM!apps/webapp/test/runOpsSplitReadGate.test.ts (1)
1-1: LGTM!Also applies to: 75-166
apps/webapp/test/runOpsSplitReadGate.glue.test.ts (1)
12-86: 🚀 Performance & ScalabilityNo issue here:
selectRunOpsTopologyreusesnewWriterwhennewReplicaUrlis unset, so these tests don’t needbuildNewReplicato return a value.apps/webapp/app/db.server.ts (1)
287-294: 🚀 Performance & ScalabilityNo change needed
.server-changes/fix-batch-item-mint-anchor.md (1)
1-7: LGTM!apps/webapp/app/runEngine/services/triggerFailedTask.server.ts (1)
46-48: LGTM!Also applies to: 90-105, 137-137
apps/webapp/app/runEngine/services/triggerFailedTask.server.test.ts (1)
1-42: LGTM!apps/webapp/test/runEngineBatchTriggerResidencyAnchoring.test.ts (1)
105-185: LGTM!apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.ts (2)
1-9: LGTM!
11-15: LGTM!apps/webapp/app/v3/runOpsMigration/mintAnchoredRunFriendlyId.server.test.ts (1)
1-31: LGTM!apps/webapp/app/runEngine/services/triggerTask.server.ts (1)
30-30: LGTM!apps/webapp/app/v3/services/batchTriggerV3.server.ts (3)
28-28: LGTM!
351-365: LGTM!
367-476: LGTM!apps/webapp/app/runEngine/services/batchTrigger.server.ts (3)
21-21: LGTM!
583-599: LGTM!
682-714: LGTM!
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Give TriggerFailedTaskService.callWithoutTraceEvents the same batch-anchored runFriendlyId override as call(), so a future batch caller of it can't mint an unanchored pre-failed run. Hoist the repeated anchored-mint expression in the BatchQueue item callback into a single local helper. Use a type alias instead of an interface in the schema-parity test, and cover the two remaining pre-failed-run branches (pre-marked error item, thrown trigger error).
Collaborator
Author
|
Thanks for the review. Addressed the nitpicks in 149909d:
Left as-is, with reasoning:
|
carderne
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes to the run-ops database split (the Cloud-only mode where run-lifecycle rows live on a dedicated Postgres). All are inert in the default single-database deployment.
The main fix: on the batch trigger paths, a parentless batch's item runs chose their physical store from a fresh per-org mint-flag read at processing time, so flipping an org's flag mid-batch could land an item in a different store than its batch, breaking the
TaskRun.batchIdforeign key (or silently orphaning the item). The other two harden the split's safety nets: the schema-parity test now actually compares columns, and the read fan-out gate now signals when it has been silently disabled.Batch item residency
RunEngineBatchTriggerService(api.v2) and the BatchQueue item callback (api.v3) now anchor each item's id mint on the batch's own friendlyId, mirroring the already-safeBatchTriggerV3Service. Residency is a pure id-shape check, so an item can no longer diverge from its batch across a mid-batch flag flip. The pre-failed-run fallback is anchored the same way (it also setsbatchId), and the shared mint branch is consolidated into one helper so every mint path stays in lockstep. No new database queries; single-database mode is unchanged (a cuid-shaped batch friendlyId yields a cuid item).Schema parity test
The parity test previously read only the dedicated schema and matched model headers with regexes, so it never compared columns and could not catch a run-subgraph column that diverged between the two physical schemas. It now parses both schemas and asserts bidirectional scalar-column parity (type, nullability, array-ness, default) across the run-subgraph models, and fails on any field line it can't parse. Scoped to the run-subgraph models so unrelated control-plane edits don't break it.
Read fan-out signal
The split read fan-out gate is decided by the object identity of the NEW vs control-plane clients. It now warns when both run-ops URLs are set but the NEW client isn't a distinct instance (fan-out silently off), and a new test exercises the real topology-into-gate wiring so a future refactor that aliases the clients can't disable fan-out unnoticed.
Verification
New unit and glue tests cover all three changes; the DB-backed residency, store-routing, and topology suites pass against real Postgres;
typecheckis clean for both packages.