fix(llm-model-catalog): format generated files so they stop showing as modified#4170
Open
1stvamp wants to merge 1 commit into
Open
fix(llm-model-catalog): format generated files so they stop showing as modified#41701stvamp wants to merge 1 commit into
1stvamp wants to merge 1 commit into
Conversation
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (26)
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the change, but it misses required template sections like Closes #issue, checklist, testing, changelog, and screenshots. |
Add the missing template sections: Closes #issue, checklist, testing steps, changelog, and screenshots, or mark them N/A if not applicable. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title is concise and accurately summarizes the main change to format generated llm-model-catalog files. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/catalog-generate-format
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…s modified generate.mjs wrote defaultPrices.ts and modelCatalog.ts with raw JSON.stringify (quoted keys, no trailing commas), but the committed files were oxfmt-formatted, so the generator output never matched HEAD. Any 'turbo run generate' (e.g. via 'pnpm run db:migrate') left both files dirty with an identical-data diff. Run oxfmt on the output as the final generate step so regeneration is a no-op.
7f1a026 to
e07d3cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anyone running
pnpm run db:migratelocally ended up withdefaultPrices.tsandmodelCatalog.tsinllm-model-catalogshowing as modified every time, a ~10k-line diff that only ever changed formatting. This makes the generator format its own output so regeneration is a clean no-op.Root cause
The root
db:migratescript ends in&& turbo run generate, which runs thegeneratescript in every package that has one, including this one. The generator wrote its output with plainJSON.stringify(quoted keys, no trailing commas), but the checked-in files had been through oxfmt (unquoted keys, trailing commas). So the generator output never matched what was committed, even though the parsed data was identical.Fix
Run oxfmt over the generated files as the last step of
generate.mjs. Verified idempotent: twogenerateruns in a row leave the.tsfiles untouched.No changeset: internal package, dev tooling only, no runtime or public API change.