-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(webapp,core): retry run resume through transient database outages #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matt-aitken
wants to merge
5
commits into
main
Choose a base branch
from
fix/resume-retriable-on-transient-db-errors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
79da4f8
fix(webapp,core): retry run resume through transient database outages
matt-aitken 8334820
fix(core): extend resume retry to the supervisor engine hop
matt-aitken 81ffb3f
docs(core): clarify what the workload resume retry covers
matt-aitken 6c615be
refactor(webapp,core): scope resume-retry fix to the server route
matt-aitken 988f53d
fix(core): jittered retry on the resume hops for transient DB outages
matt-aitken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: fix | ||
| --- | ||
|
|
||
| Runs resuming after a wait no longer fail with TASK_EXECUTION_ABORTED when the database is briefly unreachable; the resume endpoint returns a retryable response for transient infrastructure errors instead of a permanent one. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Missing changeset means the retry-on-resume fix won't ship to users in the next package release
The retry configuration is added to a published package but no changeset is included (
.server-changes/resume-retry-transient-db.mdat.server-changes/resume-retry-transient-db.md:1-6), so the version of@trigger.dev/corewon't be bumped and the behavioral change won't be released.Impact: Users running the published SDK won't get the retry-on-resume fix until a changeset is added and the package is versioned.
Repository rules require a changeset for any change under packages/
CONTRIBUTING.md states: "If you are contributing a change to any packages in this monorepo (anything in either the
/packagesor/integrationsdirectories), then you will need to add a changeset to your Pull Requests before they can be merged."The table in CONTRIBUTING.md also says: "Both packages and server → Just the changeset" (no
.server-changes/file needed).CLAUDE.md echoes: "When modifying any public package (
packages/*orintegrations/*), add a changeset."This PR modifies
packages/core/src/v3/runEngineWorker/supervisor/http.tsandpackages/core/src/v3/runEngineWorker/workload/http.ts, both underpackages/corewhich is the published@trigger.dev/corepackage. A changeset (viapnpm run changeset:add) selecting@trigger.dev/coreas apatchis required.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.