Skip to content

feat(webapp): segmented control for the task type filter#3985

Open
samejr wants to merge 1 commit into
mainfrom
samejr/segmented-control-task-filter
Open

feat(webapp): segmented control for the task type filter#3985
samejr wants to merge 1 commit into
mainfrom
samejr/segmented-control-task-filter

Conversation

@samejr

@samejr samejr commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

Replaces the multi-select popover task type filter on the Tasks page with a single-select segmented control: All plus icon-only Agent, Standard, and Scheduled segments. Each segment has a tooltip showing its label and a number-key shortcut (0-3), and the search field no longer autofocuses so the shortcuts work on page load.

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Replace the popover task type filter on the Tasks page with a segmented control: "All" plus icon-only Agent, Standard, and Scheduled segments, each with a tooltip showing its label and number-key shortcut (0-3). Filtering is now single-select instead of multi-select.
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5c62af0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The task-type filter on the Tasks index route is replaced from a multi-select popover (Combobox/Select) to a SegmentedControl with four segments: All, Agent, Standard, and Scheduled. New constants (ALL_TASK_TYPES, TaskTypeSegment, TASK_TYPE_SEGMENTS) define segment metadata including tooltip text and mapped UnifiedTaskKind. The selectedTypes derivation is updated to single-select: it returns a Set only when exactly one types URL param is present, otherwise null. TaskTypeFilter is rewritten to use useShortcutKeys for numeric 0–3 keyboard shortcuts, removes the types param for "All", and sets a single-element types array (clearing page) for a specific kind. SearchInput autoFocus is also removed. A changelog entry documents the change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: converting the task type filter to a segmented control UI component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description covers the key aspects of the change and includes the required checklist with items marked complete, but omits the Testing and Screenshots sections from the template.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/segmented-control-task-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants