feat(sdk,cli): namespace agent skills with trigger- and add cost-savings#3970
Conversation
🦋 Changeset detectedLatest commit: 603d5e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughAll agent skills are renamed to use a 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| async function collectManifest(): Promise<string[]> { | ||
| const entries = await fs.readdir(skillsDir, { withFileTypes: true }).catch(() => []); | ||
| const all = new Set<string>(); | ||
|
|
||
| for (const entry of entries) { | ||
| if (!entry.isDirectory()) continue; | ||
| const skillMd = path.join(skillsDir, entry.name, "SKILL.md"); | ||
| const sources = await readSkillSources(skillMd).catch(() => []); | ||
| for (const s of sources) { | ||
| // Only bundle docs paths; ignore anything that isn't a docs/*.mdx source. | ||
| if (s.startsWith("docs/") && s.endsWith(".mdx")) all.add(s); | ||
| } | ||
| const docsJson = JSON.parse(await fs.readFile(path.join(docsRoot, "docs.json"), "utf8")); | ||
| const dropdowns: Array<{ dropdown?: string }> = docsJson?.navigation?.dropdowns ?? []; | ||
| const documentation = dropdowns.find((d) => d.dropdown === DROPDOWN); | ||
|
|
||
| if (!documentation) { | ||
| throw new Error(`[bundleSdkDocs] "${DROPDOWN}" dropdown not found in docs/docs.json`); | ||
| } | ||
|
|
||
| return [...all].sort(); | ||
| // Page paths are root-relative without extension (e.g. "tasks/overview"); map to docs/*.mdx. | ||
| return [...new Set(collectPages(documentation))]; |
There was a problem hiding this comment.
🚩 bundleSdkDocs now bundles significantly more docs than before
The old approach bundled only docs explicitly cited in skill sources: frontmatter (a curated set of ~30-40 pages). The new approach bundles the entire "Documentation" dropdown from docs.json, which includes ~130+ pages across Getting started, Fundamentals, Writing tasks, Agents, Configuration, Deployment, Realtime, CLI, Observability, Troubleshooting, Self-hosting, etc. This is a substantial increase in bundled content that will increase the published @trigger.dev/sdk package size. This seems intentional (the comment says "every page under it is bundled"), but the package size impact should be considered.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5e3db042-e160-4a73-8dd4-0ef1d66dd596
📒 Files selected for processing (16)
.changeset/trigger-skill-namespace-and-docs.mddocs/mcp-agent-rules.mdxdocs/skills.mdxpackages/cli-v3/skills/trigger-authoring-chat-agent/SKILL.mdpackages/cli-v3/skills/trigger-authoring-tasks/SKILL.mdpackages/cli-v3/skills/trigger-chat-agent-advanced/SKILL.mdpackages/cli-v3/skills/trigger-cost-savings/SKILL.mdpackages/cli-v3/skills/trigger-getting-started/SKILL.mdpackages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.mdpackages/cli-v3/src/commands/init.tspackages/trigger-sdk/skills/trigger-authoring-chat-agent/SKILL.mdpackages/trigger-sdk/skills/trigger-authoring-tasks/SKILL.mdpackages/trigger-sdk/skills/trigger-chat-agent-advanced/SKILL.mdpackages/trigger-sdk/skills/trigger-cost-savings/SKILL.mdpackages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.mdscripts/bundleSdkDocs.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (7)
docs/**/*.mdx
📄 CodeRabbit inference engine (docs/CLAUDE.md)
docs/**/*.mdx: MDX documentation pages must include frontmatter with title (required), description (required), and sidebarTitle (optional) in YAML format
Use Mintlify components for structured content: , , , , , , /, /
Always import from@trigger.dev/sdkin code examples (never from@trigger.dev/sdk/v3)
Code examples must be complete and runnable where possible
Use language tags in code fences:typescript,bash,json
Files:
docs/mcp-agent-rules.mdxdocs/skills.mdx
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.mdpackages/cli-v3/skills/trigger-cost-savings/SKILL.mdpackages/cli-v3/skills/trigger-authoring-chat-agent/SKILL.mdpackages/trigger-sdk/skills/trigger-authoring-chat-agent/SKILL.mdpackages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.mdpackages/trigger-sdk/skills/trigger-authoring-tasks/SKILL.mdpackages/cli-v3/skills/trigger-chat-agent-advanced/SKILL.mdpackages/trigger-sdk/skills/trigger-chat-agent-advanced/SKILL.mdpackages/cli-v3/skills/trigger-authoring-tasks/SKILL.mdpackages/cli-v3/skills/trigger-getting-started/SKILL.mdpackages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.tspackages/trigger-sdk/skills/trigger-cost-savings/SKILL.md
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects insteadImport from
@trigger.dev/sdkwhen writing Trigger.dev tasks. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob
Files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved, code splitting is needed for performance, or the module must be loaded conditionally at runtime
Import subpaths only frompackages/core(@trigger.dev/core), never import from the root
Files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
packages/cli-v3/src/commands/**/*
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
CLI command definitions should be located in
src/commands/
Files:
packages/cli-v3/src/commands/init.ts
packages/cli-v3/src/commands/init.ts
📄 CodeRabbit inference engine (packages/cli-v3/CLAUDE.md)
Implement
init.tscommand insrc/commands/for project initialization
Files:
packages/cli-v3/src/commands/init.ts
🧠 Learnings (9)
📚 Learning: 2026-03-10T12:44:14.176Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:14.176Z
Learning: In the trigger.dev repo, docs PRs are often companions to implementation PRs. When reviewing docs PRs (MDX files under docs/), check the PR description for any companion/related PR references and verify that the documented features exist in those companion PRs before flagging missing implementations. This ensures docs stay in sync with code changes across related PRs.
Applied to files:
docs/mcp-agent-rules.mdxdocs/skills.mdx
📚 Learning: 2026-04-30T20:30:29.458Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3226
File: docs/ai-chat/quick-start.mdx:13-13
Timestamp: 2026-04-30T20:30:29.458Z
Learning: In this repo’s documentation MDX files (`docs/**/*.mdx`), use `ts` and `tsx` (not `typescript`) as the code-fence language tags for TypeScript/TSX snippets. Do not flag `ts`/`tsx` code-fence language tags as incorrect in any docs MDX file, since this is the site-wide Mintlify-compatible convention.
Applied to files:
docs/mcp-agent-rules.mdxdocs/skills.mdx
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/cli-v3/src/commands/init.tsscripts/bundleSdkDocs.ts
🪛 LanguageTool
packages/trigger-sdk/skills/trigger-cost-savings/SKILL.md
[uncategorized] ~116-~116: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... (see the adjacent package.json). The full cost documentation ships alongside it under ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🪛 SkillSpector (2.1.1)
packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.md
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
packages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.md
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
🔇 Additional comments (10)
packages/cli-v3/skills/trigger-getting-started/SKILL.md (1)
1-214: LGTM!packages/cli-v3/skills/trigger-authoring-tasks/SKILL.md (1)
1-57: LGTM!packages/cli-v3/skills/trigger-authoring-chat-agent/SKILL.md (1)
1-60: LGTM!packages/cli-v3/skills/trigger-chat-agent-advanced/SKILL.md (1)
1-70: LGTM!packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.md (1)
1-58: LGTM!packages/cli-v3/skills/trigger-cost-savings/SKILL.md (1)
1-35: LGTM!docs/skills.mdx (1)
1-91: LGTM!docs/mcp-agent-rules.mdx (1)
1-41: LGTM!packages/cli-v3/src/commands/init.ts (1)
238-246: Skill name references updated correctly in AI hand-off outro.Lines 240 and 242 now reference
trigger-getting-started, which aligns with the context snippet frompackages/cli-v3/skills/trigger-getting-started/SKILL.mdconfirming the skill's declared name. The conditional logic for different tooling combinations is preserved correctly..changeset/trigger-skill-namespace-and-docs.md (1)
1-7: Changeset structure and content are correct.The file properly declares patch bumps for both
@trigger.dev/sdkandtrigger.dev, and the description accurately reflects the three changes: (1)trigger-namespace prefix on skills, (2) newtrigger-cost-savingsskill, and (3) full Trigger.dev documentation bundling. Wording and scope match the PR objectives.
| description: > | ||
| Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when | ||
| asked to reduce spend, optimize costs, audit usage, right-size machines, or review task | ||
| efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP | ||
| tools (list_runs, get_run_details, get_current_worker). |
There was a problem hiding this comment.
Use parser-compatible frontmatter for description.
Line 3 uses description: >, but the SDK frontmatter parser only supports simple single-line key: value strings; this will load description as just ">" instead of the intended text.
Suggested fix
-description: >
- Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when
- asked to reduce spend, optimize costs, audit usage, right-size machines, or review task
- efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP
- tools (list_runs, get_run_details, get_current_worker).
+description: Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when asked to reduce spend, optimize costs, audit usage, right-size machines, or review task efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP tools (list_runs, get_run_details, get_current_worker).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| description: > | |
| Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when | |
| asked to reduce spend, optimize costs, audit usage, right-size machines, or review task | |
| efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP | |
| tools (list_runs, get_run_details, get_current_worker). | |
| description: Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when asked to reduce spend, optimize costs, audit usage, right-size machines, or review task efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP tools (list_runs, get_run_details, get_current_worker). |
| for (const rel of manifest) { | ||
| const src = path.join(repoRoot, rel); | ||
| const src = path.join(docsRoot, `${rel}.mdx`); | ||
| try { | ||
| await fs.access(src); | ||
| } catch { | ||
| // A nav entry pointing at a nonexistent page is a docs-nav issue, not a bundler one. | ||
| // Warn and skip rather than fail the SDK build. | ||
| missing.push(rel); | ||
| continue; | ||
| } | ||
| // Strip the leading "docs/" so files land at <sdk>/docs/<subpath>. | ||
| const dest = path.join(outDir, rel.slice("docs/".length)); | ||
| const dest = path.join(outDir, `${rel}.mdx`); | ||
| await fs.mkdir(path.dirname(dest), { recursive: true }); |
There was a problem hiding this comment.
Validate nav-derived paths before filesystem joins.
On Line 79 and Line 88, rel from docs/docs.json is used directly in path.join(...). A malformed nav entry like ../... can escape docsRoot/outDir and copy unintended files into the package.
Suggested fix
for (const rel of manifest) {
- const src = path.join(docsRoot, `${rel}.mdx`);
+ const safeRel = path.posix.normalize(rel);
+ if (path.isAbsolute(safeRel) || safeRel.startsWith("..") || safeRel.includes("/../")) {
+ throw new Error(`[bundleSdkDocs] invalid nav path "${rel}" under "${DROPDOWN}"`);
+ }
+
+ const src = path.join(docsRoot, `${safeRel}.mdx`);
try {
await fs.access(src);
} catch {
// A nav entry pointing at a nonexistent page is a docs-nav issue, not a bundler one.
// Warn and skip rather than fail the SDK build.
missing.push(rel);
continue;
}
- const dest = path.join(outDir, `${rel}.mdx`);
+ const dest = path.join(outDir, `${safeRel}.mdx`);| if (missing.length > 0) { | ||
| console.error( | ||
| `[bundleSdkDocs] ${missing.length} doc source(s) cited by a skill do not exist:\n` + | ||
| missing.map((m) => ` - ${m}`).join("\n") + | ||
| `\nFix the skill's sources: list or add the doc.` | ||
| console.warn( | ||
| `[bundleSdkDocs] ${missing.length} "${DROPDOWN}" nav page(s) have no .mdx and were skipped:\n` + | ||
| missing.map((m) => ` - ${m}`).join("\n") | ||
| ); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| console.log(`[bundleSdkDocs] bundled ${copied} docs into ${path.relative(repoRoot, outDir)}`); | ||
| console.log( | ||
| `[bundleSdkDocs] bundled ${copied} docs from the "${DROPDOWN}" nav into ${path.relative( | ||
| repoRoot, | ||
| outDir | ||
| )}` | ||
| ); | ||
| } |
There was a problem hiding this comment.
Fail the build when all nav pages are skipped.
If every src is missing, the script logs warnings and exits successfully with copied === 0, yielding an empty bundled docs directory while reporting success.
Suggested fix
if (missing.length > 0) {
console.warn(
`[bundleSdkDocs] ${missing.length} "${DROPDOWN}" nav page(s) have no .mdx and were skipped:\n` +
missing.map((m) => ` - ${m}`).join("\n")
);
}
+ if (copied === 0) {
+ throw new Error(`[bundleSdkDocs] 0 docs copied from "${DROPDOWN}" nav; refusing empty SDK docs bundle`);
+ }
+
console.log(📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (missing.length > 0) { | |
| console.error( | |
| `[bundleSdkDocs] ${missing.length} doc source(s) cited by a skill do not exist:\n` + | |
| missing.map((m) => ` - ${m}`).join("\n") + | |
| `\nFix the skill's sources: list or add the doc.` | |
| console.warn( | |
| `[bundleSdkDocs] ${missing.length} "${DROPDOWN}" nav page(s) have no .mdx and were skipped:\n` + | |
| missing.map((m) => ` - ${m}`).join("\n") | |
| ); | |
| process.exit(1); | |
| } | |
| console.log(`[bundleSdkDocs] bundled ${copied} docs into ${path.relative(repoRoot, outDir)}`); | |
| console.log( | |
| `[bundleSdkDocs] bundled ${copied} docs from the "${DROPDOWN}" nav into ${path.relative( | |
| repoRoot, | |
| outDir | |
| )}` | |
| ); | |
| } | |
| if (missing.length > 0) { | |
| console.warn( | |
| `[bundleSdkDocs] ${missing.length} "${DROPDOWN}" nav page(s) have no .mdx and were skipped:\n` + | |
| missing.map((m) => ` - ${m}`).join("\n") | |
| ); | |
| } | |
| if (copied === 0) { | |
| throw new Error(`[bundleSdkDocs] 0 docs copied from "${DROPDOWN}" nav; refusing empty SDK docs bundle`); | |
| } | |
| console.log( | |
| `[bundleSdkDocs] bundled ${copied} docs from the "${DROPDOWN}" nav into ${path.relative( | |
| repoRoot, | |
| outDir | |
| )}` | |
| ); | |
| } |
The installed skills now use a `trigger-` prefix (`trigger-authoring-tasks`, `trigger-getting-started`, and so on) so they do not collide with non-Trigger skills in a shared agent skills directory, matching the public skills repo. Adds `trigger-cost-savings`: an MCP-driven audit that right-sizes machines, flags missing `maxDuration`, and spots sequential triggers that could batch. `@trigger.dev/sdk` now bundles the entire Documentation section of the docs (not just a curated subset), so an agent has the full version-pinned reference in node_modules. The build derives the set from the docs navigation, so it stays in sync automatically.
95db45c to
603d5e4
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/trigger-sdk/skills/trigger-cost-savings/SKILL.md (1)
3-7:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFrontmatter
descriptionmust be a single line (unresolved from prior review).The
description: >multiline YAML block scalar will not parse correctly. The SDK's frontmatter parser only supports single-linekey: valuepairs; it will readdescriptionas just">"instead of the intended text. Collapse the description to a single line.🐛 Proposed fix
-description: > - Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when - asked to reduce spend, optimize costs, audit usage, right-size machines, or review task - efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP - tools (list_runs, get_run_details, get_current_worker). +description: "Analyze Trigger.dev tasks, schedules, and runs for cost optimization opportunities. Use when asked to reduce spend, optimize costs, audit usage, right-size machines, or review task efficiency. Combines static source analysis with live run analysis via the Trigger.dev MCP tools (list_runs, get_run_details, get_current_worker)."
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7f96d702-97d9-4db6-90b3-61789b9be626
📒 Files selected for processing (16)
.changeset/trigger-skill-namespace-and-docs.mddocs/mcp-agent-rules.mdxdocs/skills.mdxpackages/cli-v3/skills/trigger-authoring-chat-agent/SKILL.mdpackages/cli-v3/skills/trigger-authoring-tasks/SKILL.mdpackages/cli-v3/skills/trigger-chat-agent-advanced/SKILL.mdpackages/cli-v3/skills/trigger-cost-savings/SKILL.mdpackages/cli-v3/skills/trigger-getting-started/SKILL.mdpackages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.mdpackages/cli-v3/src/commands/init.tspackages/trigger-sdk/skills/trigger-authoring-chat-agent/SKILL.mdpackages/trigger-sdk/skills/trigger-authoring-tasks/SKILL.mdpackages/trigger-sdk/skills/trigger-chat-agent-advanced/SKILL.mdpackages/trigger-sdk/skills/trigger-cost-savings/SKILL.mdpackages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.mdscripts/bundleSdkDocs.ts
✅ Files skipped from review due to trivial changes (10)
- packages/trigger-sdk/skills/trigger-authoring-tasks/SKILL.md
- packages/cli-v3/skills/trigger-cost-savings/SKILL.md
- packages/cli-v3/src/commands/init.ts
- docs/mcp-agent-rules.mdx
- packages/cli-v3/skills/trigger-authoring-tasks/SKILL.md
- packages/cli-v3/skills/trigger-getting-started/SKILL.md
- packages/cli-v3/skills/trigger-chat-agent-advanced/SKILL.md
- packages/cli-v3/skills/trigger-authoring-chat-agent/SKILL.md
- packages/trigger-sdk/skills/trigger-authoring-chat-agent/SKILL.md
- packages/trigger-sdk/skills/trigger-chat-agent-advanced/SKILL.md
🚧 Files skipped from review as they are similar to previous changes (2)
- .changeset/trigger-skill-namespace-and-docs.md
- scripts/bundleSdkDocs.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (39)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: sdk-compat / Cloudflare Workers
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: sdk-compat / Deno Runtime
- GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: sdk-compat / Bun Runtime
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: typecheck / typecheck
- GitHub Check: Build and publish previews
- GitHub Check: audit
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.mdx
📄 CodeRabbit inference engine (docs/CLAUDE.md)
docs/**/*.mdx: MDX documentation pages must include frontmatter with title (required), description (required), and sidebarTitle (optional) in YAML format
Use Mintlify components for structured content: , , , , , , /, /
Always import from@trigger.dev/sdkin code examples (never from@trigger.dev/sdk/v3)
Code examples must be complete and runnable where possible
Use language tags in code fences:typescript,bash,json
Files:
docs/skills.mdx
**/*.{js,ts,tsx,jsx,css,json,md}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier for code formatting and run
pnpm run formatbefore committing
Files:
packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.mdpackages/trigger-sdk/skills/trigger-cost-savings/SKILL.mdpackages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.md
🧠 Learnings (2)
📚 Learning: 2026-03-10T12:44:14.176Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3200
File: docs/config/config-file.mdx:353-368
Timestamp: 2026-03-10T12:44:14.176Z
Learning: In the trigger.dev repo, docs PRs are often companions to implementation PRs. When reviewing docs PRs (MDX files under docs/), check the PR description for any companion/related PR references and verify that the documented features exist in those companion PRs before flagging missing implementations. This ensures docs stay in sync with code changes across related PRs.
Applied to files:
docs/skills.mdx
📚 Learning: 2026-04-30T20:30:29.458Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3226
File: docs/ai-chat/quick-start.mdx:13-13
Timestamp: 2026-04-30T20:30:29.458Z
Learning: In this repo’s documentation MDX files (`docs/**/*.mdx`), use `ts` and `tsx` (not `typescript`) as the code-fence language tags for TypeScript/TSX snippets. Do not flag `ts`/`tsx` code-fence language tags as incorrect in any docs MDX file, since this is the site-wide Mintlify-compatible convention.
Applied to files:
docs/skills.mdx
🪛 LanguageTool
docs/skills.mdx
[uncategorized] ~27-~27: The official name of this software platform is spelled with a capital “H”.
Context: ... (.claude/skills/, .cursor/skills/, .github/skills/, .agents/skills/). It also a...
(GITHUB)
packages/trigger-sdk/skills/trigger-cost-savings/SKILL.md
[uncategorized] ~116-~116: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... (see the adjacent package.json). The full cost documentation ships alongside it under ...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🪛 SkillSpector (2.1.1)
packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.md
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 29: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
packages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.md
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
[error] 235: [PE3] Credential Access: Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Remediation: Remove references to credential paths. Use environment variables or secrets managers. For docs, use placeholder paths (e.g., /path/to/config). Never load .env or token files in production code paths.
(Privilege Escalation (PE3))
🔇 Additional comments (6)
docs/skills.mdx (1)
1-51: LGTM!packages/cli-v3/skills/trigger-realtime-and-frontend/SKILL.md (1)
2-2: LGTM!Also applies to: 13-13, 22-22, 58-58
packages/trigger-sdk/skills/trigger-cost-savings/SKILL.md (2)
25-46: LGTM! Documentation paths, MCP prerequisites, workflow, and principles are clear and complete.
91-116: LGTM! Cost table, principles, and versioning info are well-structured and accurate.packages/trigger-sdk/skills/trigger-realtime-and-frontend/SKILL.md (2)
2-2: LGTM!Also applies to: 13-13, 265-266
30-276: LGTM! Code examples are complete, runnable, and properly tagged withts/tsxlanguage identifiers. Documentation structure and sibling-skill references are correct and consistent.
Summary
Three improvements to the SDK-bundled agent skills (follow-up to the skills installer):
trigger-namespace. The installed skills (authoring-tasks,getting-started, …) had generic names that collide with unrelated skills in a shared agent skills directory. They're now prefixed —trigger-authoring-tasks,trigger-getting-started, etc. — matching the convention the public skills repo already uses.trigger-cost-savingsskill. An MCP-driven cost audit: right-sizes machines, flags missingmaxDuration, spots sequential triggers that could batch, and reviews schedule frequency, usinglist_runs/get_run_detailsfor live analysis.@trigger.dev/sdknow bundles the entire "Documentation" section of the docs (157 pages) instead of a curated 55-page subset, so an agent has the complete, version-pinned reference innode_modules.How the bundling works
scripts/bundleSdkDocs.tsnow readsdocs/docs.json, walks the "Documentation" dropdown, and copies every page under it into the SDK. The set tracks the docs navigation automatically — add a page to the nav and it ships, no skill edits needed. The API reference and Guides & examples dropdowns are intentionally excluded. A skill'ssources:frontmatter is now informational only.The dropped idea of a dedicated
trigger-configskill is replaced by references to the bundled build-extension docs (config/extensions/*) from thetrigger-authoring-tasksconfig section and the chat-agent skills.