Skip to content

ci: reduce unit test flakiness and shard re-run cost #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktrn merged 1 commit into from
Jun 5, 2026
Merged

ci: reduce unit test flakiness and shard re-run cost #3844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/unit-tests-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
name: "🧪 Unit Tests: Internal"
runs-on: ubuntu-latest
strategy:
# one flaky shard shouldn't cancel its siblings - lets us re-run only the failed shard
fail-fast: false
matrix:
shardIndex: [1, 2, 3, 4, 5, 6, 7, 8]
shardTotal: [8]
Expand Down Expand Up @@ -53,7 +55,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down Expand Up @@ -84,8 +86,8 @@ jobs:
echo "Pre-pulling Docker images with authenticated session..."
docker pull postgres:14
docker pull clickhouse/clickhouse-server:25.4-alpine
docker pull redis:7-alpine
docker pull testcontainers/ryuk:0.11.0
docker pull redis:7.2
docker pull testcontainers/ryuk:0.14.0
docker pull electricsql/electric:1.2.4
echo "Image pre-pull complete"

Expand Down Expand Up @@ -123,7 +125,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/unit-tests-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down Expand Up @@ -84,8 +84,8 @@ jobs:
echo "Pre-pulling Docker images with authenticated session..."
docker pull postgres:14
docker pull clickhouse/clickhouse-server:25.4-alpine
docker pull redis:7-alpine
docker pull testcontainers/ryuk:0.11.0
docker pull redis:7.2
docker pull testcontainers/ryuk:0.14.0
docker pull electricsql/electric:1.2.4
echo "Image pre-pull complete"

Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/unit-tests-webapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
name: "🧪 Unit Tests: Webapp"
runs-on: ubuntu-latest
strategy:
# one flaky shard shouldn't cancel its siblings - lets us re-run only the failed shard
fail-fast: false
matrix:
shardIndex: [1, 2, 3, 4, 5, 6, 7, 8]
shardTotal: [8]
Expand Down Expand Up @@ -53,7 +55,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down Expand Up @@ -84,9 +86,10 @@ jobs:
echo "Pre-pulling Docker images with authenticated session..."
docker pull postgres:14
docker pull clickhouse/clickhouse-server:25.4-alpine
docker pull redis:7-alpine
docker pull testcontainers/ryuk:0.11.0
docker pull redis:7.2
docker pull testcontainers/ryuk:0.14.0
docker pull electricsql/electric:1.2.4
docker pull minio/minio:latest
echo "Image pre-pull complete"

- name: 📥 Download deps
Expand Down Expand Up @@ -131,7 +134,7 @@ jobs:
- name: ⬇️ Checkout repo
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
fetch-depth: 1
persist-credentials: false

- name: ⎔ Setup pnpm
Expand Down
2 changes: 2 additions & 0 deletions internal-packages/run-engine/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ export default defineConfig({
test: {
include: ["**/*.test.ts"],
globals: true,
// CI-only: absorbs timing races (real-clock waits vs worker poll interval) under shard CPU contention
retry: process.env.CI ? 2 : 0,
isolate: true,
fileParallelism: false,
testTimeout: 120_000,
Expand Down
2 changes: 2 additions & 0 deletions internal-packages/schedule-engine/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { defineConfig } from "vitest/config";
export default defineConfig({
test: {
globals: true,
// CI-only: absorbs timing races (real-clock waits vs worker poll interval) under shard CPU contention
retry: process.env.CI ? 2 : 0,
environment: "node",
setupFiles: ["./test/setup.ts"],
testTimeout: 30000,
Expand Down
2 changes: 2 additions & 0 deletions packages/redis-worker/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ export default defineConfig({
test: {
include: ["**/*.test.ts"],
globals: true,
// CI-only: absorbs timing races (real-clock waits vs worker poll interval) under shard CPU contention
retry: process.env.CI ? 2 : 0,
fileParallelism: false,
},
});
Loading