Skip to content

Removed the inaccurate usage prediction bar#1326

Merged
samejr merged 1 commit into
mainfrom
remove-usage-projection
Sep 19, 2024
Merged

Removed the inaccurate usage prediction bar#1326
samejr merged 1 commit into
mainfrom
remove-usage-projection

Conversation

@samejr

@samejr samejr commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The predicted usage bar was confusing many people because the predictions weren't accurate. They were either way too high or too low. For now, we're turning it off and in the future we'll be adding spending limits and will revisit this then.

  • Removed the usage code from the component
  • Removed the usage components from the usage route
  • Adjust the layout so the number

CleanShot 2024-09-19 at 11 25 12@2x

@samejr samejr requested a review from matt-aitken September 19, 2024 10:53
@changeset-bot

changeset-bot Bot commented Sep 19, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22100e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes involve modifications to the UsageBar component and the Page component within a specific route file. The UsageBar component has had its projectedUsage prop removed, simplifying the parameters and calculations related to usage display. Additionally, the JSX structure of the Page component has been refactored to enhance clarity, including the removal of unnecessary fragments and adjustments to styling classes. The integration of the UsageBar component has been streamlined, with conditional logic for passing props remaining intact.

Changes

Files Change Summary
apps/webapp/app/components/billing/v3/UsageBar.tsx Removed projectedUsage prop from UsageBar, simplifying parameters and calculations. Adjusted vertical padding from py-12 to py-6.
apps/webapp/app/routes/_app.orgs.$organizationSlug.v3.usage/route.tsx Refactored JSX structure by removing unnecessary fragments and adjusting class names for styling. Integrated UsageBar directly with conditional projectedUsage prop.

Poem

🐇 In the meadow where the code does play,
A UsageBar shines bright today!
No more projections, just the now,
Simplicity reigns, take a bow!
With clearer paths and styling neat,
Our rabbit hearts skip a joyful beat! 🌼

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6952ec2 and 22100e8.

Files selected for processing (2)
  • apps/webapp/app/components/billing/v3/UsageBar.tsx (2 hunks)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.v3.usage/route.tsx (1 hunks)
Additional comments not posted (4)
apps/webapp/app/components/billing/v3/UsageBar.tsx (2)

16-16: Simplifies the component by removing the projectedUsage prop.

The removal of the projectedUsage prop simplifies the UsageBar component by reducing the number of props it receives and handles. This change indicates that the component no longer needs to deal with projected usage data, which streamlines its functionality and makes it more focused.

29-29: Reduced vertical padding may impact the layout and visual appearance.

The vertical padding of the UsageBar component's container has been reduced from py-12 to py-6. This change decreases the space above and below the usage bar, which could affect the overall layout and visual balance of the component within its parent container.

Please ensure that the reduced padding does not negatively impact the readability and visual appearance of the usage bar and its surrounding elements.

apps/webapp/app/routes/_app.orgs.$organizationSlug.v3.usage/route.tsx (2)

142-149: LGTM!

The changes to the layout and styling of the usage information look good. The addition of the whitespace-nowrap class prevents text wrapping, improving the visual presentation. The conditional rendering of the header text based on isCurrentMonth and the usage of formatCurrency for formatting the current usage are correct.

160-160: LGTM!

The integration of the <UsageBar> component into the main layout looks good. The props are correctly passed:

  • current is passed the value of usage.overall.current.
  • isPaying is passed a boolean value based on the presence of currentPlan?.v3Subscription?.isPaying.
  • tierLimit is conditionally passed based on isCurrentMonth.

There are no apparent issues with the logic or syntax.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@samejr samejr changed the title Removed the usage prediction bar Removed the inaccurate usage prediction bar Sep 19, 2024
@samejr samejr merged commit b590a31 into main Sep 19, 2024
@samejr samejr deleted the remove-usage-projection branch September 19, 2024 10:58
@pkg-pr-new

pkg-pr-new Bot commented Sep 19, 2024

Copy link
Copy Markdown 
pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1326

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1326

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev@1326

pnpm add https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1326

commit: 22100e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-aitken matt-aitken matt-aitken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samejr @matt-aitken