v3: usage tracking#1163
Merged
Merged
Conversation
|
Member
|
I think "Micro" should be renamed "extra-small-1x". "Micro" feels hard to place as a size and doesn't fit with the pattern which is nice other than this. |
731aebd to
c05d958
Compare
matt-aitken
reviewed
Jun 14, 2024
| .setIssuedAt() | ||
| .setIssuer("https://id.trigger.dev") | ||
| .setAudience("https://api.trigger.dev") | ||
| .setExpirationTime("2h") |
Member
There was a problem hiding this comment.
What happens if some a task is still executing after 2 hours?
Member
|
We need to support refreshing the JWT tokens because some runs last longer than a day |
…ing that via otel and to completed task run attempts
95e1bb8 to
9523366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for adding billing support for the v3 cloud, this PR introduces the tracking of run usage, and changes the machine configuration to use preset names instead of any combination of CPU/Memory.
Machine presets:
You can also now configure a default machine in trigger.config.ts.