Minor fixes.#91
Merged
Merged
Conversation
Greatest Common Divisor: Make more terse.
Power of two: Removed unnecessary exception throwing.
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 100 100
Lines 2033 2015 -18
Branches 354 347 -7
=====================================
- Hits 2033 2015 -18
Continue to review full report at Codecov.
|
Owner
|
Thank you for the fixes @Bruce-Feldman |
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
* Get Bit: Make more terse * Power of two: Allowed 1 as a valid power of 2. Power of two: Removed unnecessary exception throwing. * Fisher Yates: Made more terse * Least Common Multiple: Fill undefined value * Greatest Common Divisor: Fill undefined value. Greatest Common Divisor: Make more terse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes/improvements to a small number of basic algorithms.