Skip to content

Update combinationSum.js #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trekhleb merged 2 commits into from
Aug 6, 2018
Merged

Update combinationSum.js #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e4c0cf
Update combinationSum.js
thewizarodofoz Aug 3, 2018
51b5219
Merge branch 'master' into patch-1
trekhleb Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/algorithms/sets/combination-sum/combinationSum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@ function combinationSumRecursive(
) {
if (remainingSum < 0) {
// By adding another candidate we've gone below zero.
// This would mean that last candidate was not acceptable.
// This would mean that the last candidate was not acceptable.
return finalCombinations;
}

if (remainingSum === 0) {
// In case if after adding the previous candidate out remaining sum
// became zero we need to same current combination since it is one
// of the answer we're looking for.
// If after adding the previous candidate our remaining sum
// became zero - we need to save the current combination since it is one
// of the answers we're looking for.
finalCombinations.push(currentCombination.slice());

return finalCombinations;
}

// In case if we haven't reached zero yet let's continue to add all
// If we haven't reached zero yet let's continue to add all
// possible candidates that are left.
for (let candidateIndex = startFrom; candidateIndex < candidates.length; candidateIndex += 1) {
const currentCandidate = candidates[candidateIndex];
Expand Down