Skip to content

Fix import in a loop#472

Merged
hqsz merged 1 commit into
tortoise:developfrom
alekseitylindus:develop
Jul 31, 2020
Merged

Fix import in a loop#472
hqsz merged 1 commit into
tortoise:developfrom
alekseitylindus:develop

Conversation

@alekseitylindus
Copy link
Copy Markdown
Contributor

@alekseitylindus alekseitylindus commented Jul 28, 2020

Description

Delete import from the loop body

Motivation and Context

There is no need to import the function in each iteration

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

hqsz
hqsz requested changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hqsz hqsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. It looks small, but it is very good and clear 👍 Just for fix CI, please execute make style and fix this PR :)

@alekseitylindus
Copy link
Copy Markdown
Contributor Author

alekseitylindus commented Jul 29, 2020

@lntuition thanks, done! :)

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1763

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 96.965%
Totals Coverage Status
Change from base Build 1752: 0.004%
Covered Lines: 4112
Relevant Lines: 4196
💛 - Coveralls

@alekseitylindus alekseitylindus requested a review from hqsz July 29, 2020 14:32
hqsz
hqsz approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hqsz hqsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍 Could you please add yourself to CONTRIBUTORS.rst?

@alekseitylindus
Copy link
Copy Markdown
Contributor Author

alekseitylindus commented Jul 30, 2020

Done!

@hqsz
Copy link
Copy Markdown
Collaborator

hqsz commented Jul 31, 2020

Thank you for doing this :)

@hqsz hqsz merged commit 7e5a384 into tortoise:develop Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hqsz hqsz hqsz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alekseitylindus @coveralls @hqsz