PM-5203 approval phase ai only#1910
Open
vas3a wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/
What's in this PR?
This pull request primarily refactors the AI Approval tab in the review app to remove the ability for admins and managers to directly edit and save workflow scores from the AI reviews table. Instead, users are now directed to view the full scorecard for a submission to inspect workflow scores. Additionally, the logic for generating response options for scorecard questions is consolidated into a utility function, reducing duplication across components.
Refactor and Removal of Inline Editing in AI Approval Tab:
TabContentAiApprovalcomponent. Users can no longer edit or save scores directly from the AI reviews table. Instead, a "View scorecard" button is provided to navigate to the detailed scorecard view.Consolidation of Score Response Option Logic:
AppealCommentandManagerCommentcomponents with a single utility functiongetScoreResponseOptions, simplifying code and ensuring consistency.These changes streamline the review workflow, reduce code duplication, and guide users to the appropriate place for managing workflow scores.