Skip to content

libtmux: Improved options and hooks #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tony wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

libtmux: Improved options and hooks #925

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6875d29
py(deps) Point to git+https://github.com/tmux-python/libtmux.git#impr…
tony Apr 6, 2024
0480763
test(builder): Fixes for libtmux `.show_options`
tony Apr 6, 2024
96fb7df
test(builder): Update for `_show_options` conversions
tony Apr 6, 2024
2c0dcd3
test(builder): `show_window_option` -> `_show_option`
tony Apr 6, 2024
5bb840e
test(builder): `set_window_option` -> `set_option`
tony Apr 6, 2024
141e061
builder: `show_window_option` -> `_show_option`
tony Apr 6, 2024
777a644
builder: `set_window_option` -> `set_option`
tony Apr 6, 2024
a02bb78
docs(builder): Update docstring for `window_options` -> `window.options`
tony Apr 6, 2024
1c07069
freezer: `show_window_option` -> `_show_option`
tony Apr 6, 2024
bfdf0d0
test(builder): Remove unused loop variables
tony Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(builder): show_window_option -> _show_option
  • Loading branch information
@tony
tony committed Nov 26, 2024
commit 2c0dcd398ede37368b59fc97e7290f70c987a561
16 changes: 9 additions & 7 deletions tests/workspace/test_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ def test_focus_pane_index(session: Session) -> None:

assert session.active_window.name == "focused window"

_pane_base_index = session.active_window.show_window_option(
_pane_base_index = session.active_window._show_option(
"pane-base-index",
g=True,
_global=True,
)
assert isinstance(_pane_base_index, int)
pane_base_index = int(_pane_base_index)
Expand Down Expand Up @@ -279,7 +279,7 @@ def test_global_session_env_options(
assert isinstance(_visual_silence, bool)
assert _visual_silence is True
assert repeat_time == session._show_option("repeat-time")
assert main_pane_height == session.active_window.show_window_option(
assert main_pane_height == session.active_window._show_option(
"main-pane-height",
)

Expand All @@ -306,9 +306,9 @@ def test_window_options(
p = p
assert len(session.windows) == window_count
assert isinstance(w, Window)
assert w.show_window_option("main-pane-height") == 5
assert w._show_option("main-pane-height") == 5
if has_gte_version("2.3"):
assert w.show_window_option("pane-border-format") == " #P "
assert w._show_option("pane-border-format") == " #P "

assert len(session.windows) == window_count
window_count += 1
Expand Down Expand Up @@ -513,7 +513,7 @@ def check_window_name_mismatch() -> bool:
assert retry_until(check_window_name_mismatch, 5, interval=0.25)

def check_window_name_match() -> bool:
assert w.show_window_option("automatic-rename")
assert w._show_option("automatic-rename")
return w.name in {
pathlib.Path(os.getenv("SHELL", "bash")).name,
portable_command,
Expand Down Expand Up @@ -714,8 +714,10 @@ def test_pane_order(session: Session) -> None:
window_count += 1

for w in session.windows:
pane_base_index = w.show_window_option("pane-base-index", g=True)
pane_base_index = w._show_option("pane-base-index", _global=True)
assert isinstance(pane_base_index, int)
for p_index, p in enumerate(w.panes, start=pane_base_index):
assert p.index is not None
assert int(p_index) == int(p.index)

# pane-base-index start at base-index, pane_paths always start
Expand Down