Skip to content

Test refactoring #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tony merged 12 commits into from
Mar 13, 2022
Merged

Test refactoring #753

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8238ddf
config(flake8): Update to latest black formatting suggestion
tony Mar 13, 2022
58e426c
ci(isort): Use black config
tony Mar 13, 2022
8f057fd
tests(conf): Refactor tmpdir -> tmp_path
tony Mar 13, 2022
a1d56e3
refactor(tests): Move test dir constants to pathlib.Path
tony Mar 13, 2022
05bb102
refactor(tests): Rename constants to _dir -> _PATH and uppercase
tony Mar 13, 2022
38c5179
tests(workspacebuilder): Remove unused formatting
tony Mar 13, 2022
8e4411e
tests: Use home default directory
tony Mar 13, 2022
e2bd17d
refactor(test): Move fixtures to config_fixture fixture (say fixture …
tony Mar 13, 2022
4507f6c
tests: Delete unused constant
tony Mar 13, 2022
2e16cab
Type annotations for module
tony Mar 13, 2022
44e7670
docs: Format
tony Mar 13, 2022
733d0ed
Makefile: Include yaml files in test watching
tony Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests(workspacebuilder): Remove unused formatting
  • Loading branch information
@tony
tony committed Mar 13, 2022
commit 38c5179ad782653f982263ce2cce13fe9f2129d9
7 changes: 1 addition & 6 deletions tests/test_workspacebuilder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,6 @@ def test_before_load_throw_error_if_retcode_error(server):
config_script_fails = load_fixture("workspacebuilder/config_script_fails.yaml")
sconfig = kaptan.Kaptan(handler="yaml")
yaml = config_script_fails.format(
fixtures_dir=FIXTURES_PATH,
script_failed=FIXTURES_PATH / "script_failed.sh",
)

Expand All @@ -615,7 +614,6 @@ def test_before_load_throw_error_if_file_not_exists(server):
)
sconfig = kaptan.Kaptan(handler="yaml")
yaml = config_script_not_exists.format(
fixtures_dir=FIXTURES_PATH,
script_not_exists=FIXTURES_PATH / "script_not_exists.sh",
)
sconfig = sconfig.import_config(yaml).get()
Expand Down Expand Up @@ -643,7 +641,6 @@ def test_before_load_true_if_test_passes(server):
assert script_complete_sh.exists()
sconfig = kaptan.Kaptan(handler="yaml")
yaml = config_script_completes.format(
fixtures_dir=FIXTURES_PATH,
script_complete=script_complete_sh,
)

Expand All @@ -664,9 +661,7 @@ def test_before_load_true_if_test_passes_with_args(server):
script_complete_sh = FIXTURES_PATH / "script_complete.sh"
assert script_complete_sh.exists()
sconfig = kaptan.Kaptan(handler="yaml")
yaml = config_script_completes.format(
fixtures_dir=FIXTURES_PATH, script_complete=script_complete_sh
)
yaml = config_script_completes.format(script_complete=script_complete_sh)

sconfig = sconfig.import_config(yaml).get()
sconfig = config.expand(sconfig)
Expand Down