Skip to content

fix fail https requests without connect #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsnunes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix fail https requests without connect #620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
995446c
fix fail https requests without connect
vsnunes Jun 28, 2026
2470faa
update https without connect error message
vsnunes Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/transparent-proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ do_transparent_proxy (struct conn_s *connptr, pseudomap *hashofheaders,
size_t ulen = strlen (*url);
size_t i;

if (strncmp(*url, "https://", 7) == 0) {
log_message (LOG_ERR,
"process_request: unexpected https as destination "
"protocol for %d",
connptr->client_fd);
indicate_http_error (connptr, 400, "Bad Request",
"detail", "You tried to connect to a "
"HTTPS destination. Use CONNECT instead.",
"url", *url, NULL);
return 0;
}

data = pseudomap_find (hashofheaders, "host");
if (!data) {
union sockaddr_union dest_addr;
Expand Down