fix: Allow int keys in extra dict (getsentry#426)

vladlutkov · untitaker · commit 880b8602195f · 2019-07-11T16:26:33.000+02:00
diff --git a/sentry_sdk/integrations/logging.py b/sentry_sdk/integrations/logging.py
@@ -139,7 +139,8 @@ def _extra_from_record(record):
     return {
         k: v
         for k, v in iteritems(vars(record))
-        if k not in COMMON_RECORD_ATTRS and not k.startswith("_")
+        if k not in COMMON_RECORD_ATTRS
+        and (not isinstance(k, str) or not k.startswith("_"))
     }
 
 
diff --git a/tests/integrations/logging/test_logging.py b/tests/integrations/logging/test_logging.py
@@ -61,6 +61,17 @@ def test_logging_extra_data(sentry_init, capture_events):
     )
 
 
+def test_logging_extra_data_integer_keys(sentry_init, capture_events):
+    sentry_init(integrations=[LoggingIntegration()], default_integrations=False)
+    events = capture_events()
+
+    logger.critical("integer in extra keys", extra={1: 1})
+
+    event, = events
+
+    assert event["extra"] == {"1": 1}
+
+
 @pytest.mark.xfail(sys.version_info[:2] == (3, 4), reason="buggy logging module")
 def test_logging_stack(sentry_init, capture_events):
     sentry_init(integrations=[LoggingIntegration()], default_integrations=False)

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,8 @@ def _extra_from_record(record):`
`139`	`139`	`return {`
`140`	`140`	`k: v`
`141`	`141`	`for k, v in iteritems(vars(record))`
`142`		`- if k not in COMMON_RECORD_ATTRS and not k.startswith("_")`
	`142`	`+ if k not in COMMON_RECORD_ATTRS`
	`143`	`+ and (not isinstance(k, str) or not k.startswith("_"))`
`143`	`144`	`}`
`144`	`145`
`145`	`146`