fix: Allow int keys in extra dict#426
Merged
Merged
Conversation
untitaker
requested changes
Jul 11, 2019
Member
untitaker
left a comment
There was a problem hiding this comment.
Nice catch!
Could you add one test in test_logging.py?
b0f5d04 to
dfa7878
Compare
Contributor
Author
|
I added a test |
Member
|
Sorry but could you run |
dfa7878 to
c70b743
Compare
untitaker
approved these changes
Jul 11, 2019
Member
|
Thanks! Do you need a release for this right now or is this just something you happened to come by? |
Contributor
Author
|
Thanks, I'm ready to wait until the next release. |
Member
|
You've just found a regression in the docs, please refer to
getsentry/sentry-docs#1112.
…On Fri, Jul 12, 2019 at 7:06 PM vladlutkov ***@***.***> wrote:
Thanks, I'm ready to wait until the next release.
Off-topic
Does the library only support python 3 and higher?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#426?email_source=notifications&email_token=AAGMPRI4PFDSURDSVLZMT7DP7C2ZPA5CNFSM4IBDHDG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ2KOII#issuecomment-510961441>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGMPRIUBVYPCN5QUWXIXADP7C2ZPANCNFSM4IBDHDGQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I pass dict with int keys in extra keyword argument
I'll get an exception and event will not be sent.