refactor: replace mime with mrmime for smaller bundle size#504
Open
raghavsharma29 wants to merge 1 commit into
Open
refactor: replace mime with mrmime for smaller bundle size#504raghavsharma29 wants to merge 1 commit into
raghavsharma29 wants to merge 1 commit into
Conversation
Swaps the mime package for mrmime across res, type-is, accepts, and send packages. mrmime is ~5x smaller and provides equivalent functionality via lookup() as a drop-in replacement for mime's getType(), since only standard mime type lookups were needed. Fixes tinyhttp#499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the mime package for mrmime across res, type-is, accepts, and send packages. mrmime is ~5x smaller and provides equivalent functionality via lookup() as a drop-in replacement for mime's getType(), since only standard mime type lookups were needed.
Fixes #499
Summary
Replaces
mimewithmrmimeacross the codebase, as suggested in #499.Why
mrmimeis ~5x smaller thanmimeand provides everything needed herevia its
lookup()function, equivalent tomime'sgetType(). Sinceonly standard mime type lookups are used (no custom type registration),
mrmimeis a clean drop-in replacement.Changes
packages/res/src/headers.tspackages/res/src/util.tspackages/type-is/src/index.tspackages/accepts/src/index.tspackages/send/src/sendFile.tspackage.jsondependencies in each affected packageTesting
unrelated to this change)
Fixes #499