Skip to content

test: cover uncovered branches in app, req and negotiator #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nameless1020 wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

test: cover uncovered branches in app, req and negotiator #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/core/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ describe('Testing App routing', () => {

await makeFetch(app.listen())('/abc').expect(200, 'Hello World')
})
it('should ignore a non-string, non-array base path and mount at root', async () => {
const app = new App()

app.use(123 as unknown as string, (_req, res) => void res.send('Hello world'))

await makeFetch(app.listen())('/').expect(200, 'Hello world')
})
it('should can set url prefix for the application', async () => {
const app = new App()

Expand Down
7 changes: 7 additions & 0 deletions tests/core/request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,4 +794,11 @@ describe('Request properties', () => {

await fetch('/', { headers: { 'If-None-Match': etag, 'Cache-Control': 'max-age=3600' } }).expectStatus(304)
})
it('req.stale is true when the response is not fresh', async () => {
const { fetch } = InitAppAndTest((req, res) => {
res.send(`stale: ${req.stale}`)
})

await fetch('/').expect(200, 'stale: true')
})
})
10 changes: 10 additions & 0 deletions tests/modules/negotiator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,16 @@ describe('Negotiator', () => {
const negotiator = new Negotiator(createRequest({ accept: 'text/html;level' }))
expect(negotiator.mediaTypes()).toEqual(['text/html'])
})

it('should match when accept parameter has an empty value', () => {
const negotiator = new Negotiator(createRequest({ accept: 'text/html;level=' }))
expect(negotiator.mediaTypes(['text/html;level='])).toEqual(['text/html;level='])
})

it('should not match when accept parameter has an empty value but provided does not', () => {
const negotiator = new Negotiator(createRequest({ accept: 'text/html;level=' }))
expect(negotiator.mediaTypes(['text/html;level=1'])).toEqual([])
})
})

describe('edge cases', () => {
Expand Down