Get CI passing again - #274
Open
CosmicHorrorDev wants to merge 3 commits into
Open
Conversation
Author
|
(submitting this PR as I have some other changes I'd like to get merged, and this seemed like a good place to start) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets CI to where it's passing again (example run)
Notably the MSRV had to be bumped due to dependencies raising their MSRVs and the lack of an MSRV-aware resolver. I also moved the MSRV checking to it's own, more minimal, CI job that only takes into account building and testing with the default feature set since that's how MSRVs are usually handled
Finally dd09d10 moves linting into the standard build the whole app job. That just leaves formatting in its own job, so I dropped the feature matrix since it doesn't impact formatting
In the end all of that leaves 10 jobs now compared to the previous 16