Listen config parser - #260
Open
mpalmer wants to merge 4 commits into
Open
Conversation
This change provides the ability for a tiny-http user to go straight from a string to a listener configuration, simplifying consumer code and making it easier for downstream projects to adopt Unix socket support, in particular.
This trait allows consumers to continue to accept strings as listen configs, while still allowing them the flexibility to accept other listen configs too. Essentially, the entire rationale for the existence of std::net::ToSocketAddrs is included here by reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements some "helper" code for projects that build on tiny-http, by providing functionality that can parse a string to produce a ConfigListenAddr. In particular, it differentiates between IP (
<IP|host>:<port>) and Unix sockets (on platforms that support them;unix:<path>), as the Unix socket use case is important for my work.