Fix #646 - Fix calculation hit ratio in StandardCache's cache report.#647
Merged
Merged
Conversation
danielfernandez
approved these changes
Nov 4, 2017
Member
|
Thanks a lot @yoshikawaa! |
Contributor
Author
|
@danielfernandez |
php-coder
reviewed
Dec 21, 2017
| long getCount = getGetCount(); | ||
|
|
||
| double hitRatio = hitCount / getCount; | ||
| double hitRatio = (double) hitCount / (double) getCount; |
There was a problem hiding this comment.
@yoshikawaa @danielfernandez Why not use getHitRatio() method to reduce duplication? This also adds a protection against division by zero.
php-coder
reviewed
Dec 21, 2017
|
|
||
| double hitRatio = hitCount / getCount; | ||
| double hitRatio = (double) hitCount / (double) getCount; | ||
| double missRatio = 1 - hitRatio; |
There was a problem hiding this comment.
double missRatio = 1 - hitRatio;
BTW this can be replaced by using getMissRatio() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#646 fixed.
Please check it, Thanks.