Migration - BouncyCastle Fallback - #92
Closed
0xFirekeeper wants to merge 2 commits into
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 78.17% 78.20% +0.02%
==========================================
Files 28 28
Lines 4358 4358
Branches 610 610
==========================================
+ Hits 3407 3408 +1
Misses 787 787
+ Partials 164 163 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Too risky to use two algorithms here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
SignOutAsyncmethod in theEmbeddedWallet.Misc.csfile by adding a fallback encryption mechanism using BouncyCastle when the initial AES encryption fails.Detailed summary
usingstatements for BouncyCastle cryptography classes.AesEngineandPaddedBufferedBlockCipher.