module: rtnr: rework module to use only sink/source api#11021
Open
softwarecki wants to merge 1 commit into
Open
module: rtnr: rework module to use only sink/source api#11021softwarecki wants to merge 1 commit into
softwarecki wants to merge 1 commit into
Conversation
Rework the RTNR module to only use the sink/source API to prepare SOF for the full transition to pipeline 2.0. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
Copilot,
piotrhoppeintel,
serhiy-katsyuba-intel,
tmleman and
wjablon1
July 21, 2026 16:10
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 21, 2026 16:10
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks the RTNR processing module to use the newer sink/source API end-to-end, aligning it with the pipeline 2.0 transition plan. The change replaces direct audio_stream manipulation (and manual position tracking) with explicit source acquisition / sink reservation and corresponding release/commit operations.
Changes:
- Migrated RTNR processing and preparation paths from
audio_streambuffers tosof_source/sof_sinkAPIs. - Replaced the old stream “copy helpers” with per-cycle source/sink buffer acquisition helpers suitable for the sink/source API.
- Simplified the stub RTNR implementation to a direct circular-buffer passthrough using
cir_buf_copy().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/include/sof/audio/rtnr/rtnr.h | Removes obsolete prototypes for the old audio_stream copy helpers. |
| src/audio/rtnr/rtnr.c | Switches module prepare/process code to sink/source APIs; adds buffer acquisition helpers and updates IPC4 format handling. |
| src/audio/rtnr/rtnr_stub.c | Replaces stub’s audio_stream-based copying with direct circular-buffer passthrough. |
serhiy-katsyuba-intel
approved these changes
Jul 22, 2026
Member
|
@softwarecki we are good to merge once copilot questions resolved. |
wjablon1
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the RTNR module to only use the sink/source API to prepare SOF for the full transition to pipeline 2.0.