Skip to content

ipc: use-after-free fixes #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abonislawski wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −0
Open

ipc: use-after-free fixes #10917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9ffa46
ipc4: chain_dma: free stale ipc_comp_dev on error path
abonislawski Jun 11, 2026
2bcaf7b
ipc: clear dangling pipeline comp refs on instance free
abonislawski Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/ipc/ipc-helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ __cold int ipc_comp_free(struct ipc *ipc, uint32_t comp_id)
struct ipc_comp_dev *icd;
struct comp_buffer *buffer;
struct comp_buffer *safe;
struct list_item *clist;
uint32_t flags;

assert_can_be_cold();
Expand Down Expand Up @@ -348,6 +349,24 @@ __cold int ipc_comp_free(struct ipc *ipc, uint32_t comp_id)

irq_local_enable(flags);

/*
* A completed pipeline stores raw comp_dev pointers in its
* source_comp/sink_comp/sched_comp fields.
*/
list_for_item(clist, &ipc->comp_list) {
struct ipc_comp_dev *ppl_icd = container_of(clist, struct ipc_comp_dev, list);

if (ppl_icd->type != COMP_TYPE_PIPELINE)
continue;

if (ppl_icd->pipeline->source_comp == icd->cd)
ppl_icd->pipeline->source_comp = NULL;
if (ppl_icd->pipeline->sink_comp == icd->cd)
ppl_icd->pipeline->sink_comp = NULL;
if (ppl_icd->pipeline->sched_comp == icd->cd)
ppl_icd->pipeline->sched_comp = NULL;
}
Comment thread
abonislawski marked this conversation as resolved.
Comment thread
abonislawski marked this conversation as resolved.

/* free component and remove from list */
comp_free(icd->cd);

Expand Down
7 changes: 7 additions & 0 deletions src/ipc/ipc4/handler-user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ static struct ipc_comp_dev *pipeline_get_host_dev(struct ipc_comp_dev *ppl_icd)
struct ipc *ipc = ipc_get();
int host_id;

if (!ppl_icd->pipeline->source_comp || !ppl_icd->pipeline->sink_comp) {
ipc_cmd_err(&ipc_tr, "pipeline %d: source/sink comp freed", ppl_icd->id);
return NULL;
}
Comment thread
abonislawski marked this conversation as resolved.

/* If the source component's direction is not set but the sink's direction is,
* this block will copy the direction from the sink to the source component and
* mark the source's direction as set.
Expand Down Expand Up @@ -601,6 +606,8 @@ __cold static int ipc4_process_chain_dma(struct ipc4_message_request *ipc4)
ret = ipc4_chain_dma_state(cdma_comp->cd, &cdma);
if (ret < 0) {
comp_free(cdma_comp->cd);
list_item_del(&cdma_comp->list);
rfree(cdma_comp);
return IPC4_FAILURE;
}

Expand Down
Loading