Skip to content

ipc4: handler: reject get_large_config vendor payload larger than hostbox #10851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

ipc4: handler: reject get_large_config vendor payload larger than hostbox #10851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ipc/ipc4/handler-user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,6 +1040,14 @@ __cold static int ipc4_get_large_config_module_instance(struct ipc4_message_requ

/* check for vendor param first */
if (config.extension.r.large_param_id == VENDOR_CONFIG_PARAM) {
/* data_off_size is a 20-bit host-controlled field, so it can
* claim far more than the hostbox can physically hold.
*/
if (data_offset > MAILBOX_HOSTBOX_SIZE) {
Copy link
Copy Markdown
Member

@lgirdwood lgirdwood Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include the container size or current offset in the calculation ? e.g. if object size + data_offset > MAILBOX_SIZE ?

Copy link
Copy Markdown
Collaborator

@kv2019i kv2019i Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think data is set to start of the mailbox, so this would be correct.

ipc_cmd_err(&ipc_tr, "data_off_size %u exceeds mailbox bound",
data_offset);
return IPC4_INVALID_CONFIG_DATA_STRUCT;
}
/* For now only vendor_config case uses payload from hostbox */
dcache_invalidate_region((__sparse_force void __sparse_cache *)MAILBOX_HOSTBOX_BASE,
config.extension.r.data_off_size);
Expand Down
Loading