Skip to content

audio: host-zephyr: add HOST_DMA_IPC_POSITION_UPDATES Kconfig #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kv2019i wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: host-zephyr: add HOST_DMA_IPC_POSITION_UPDATES Kconfig #10849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/audio/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ config HOST_DMA_STREAM_SYNCHRONIZATION
for each group, different than the default one determined by the system tick frequency.
This feature will allow host lower power consumption in scenarios with deep buffering.

config HOST_DMA_IPC_POSITION_UPDATES
bool "Support for stream position updates via IPC messages"
depends on IPC_MAJOR_3
default y
help
Support firmware functionality to report stream position updates
by sending an IPC message whenever one period of audio is transferred.
Most platforms provide more efficient ways to query the DMA status.

config COMP_CHAIN_DMA
bool "Chain DMA component"
depends on IPC_MAJOR_4
Expand Down
4 changes: 3 additions & 1 deletion src/audio/copier/host_copier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ struct host_data {

/* host position reporting related */
uint32_t host_size; /**< Host buffer size (in bytes) */
uint32_t report_pos; /**< Position in current report period */
uint32_t local_pos; /**< Local position in host buffer */
uint32_t host_period_bytes;
uint16_t stream_tag;
Expand Down Expand Up @@ -106,7 +105,10 @@ struct host_data {

/* stream info */
struct sof_ipc_stream_posn posn; /* TODO: update this */
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
uint32_t report_pos; /**< Position in current report period */
struct ipc_msg *msg; /**< host notification */
#endif
Comment on lines 107 to +111
Copy link
Copy Markdown
Collaborator Author

@kv2019i kv2019i Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, fixed in V2.

#if CONFIG_XRUN_NOTIFICATIONS_ENABLE
bool xrun_notification_sent;
#endif
Expand Down
12 changes: 12 additions & 0 deletions src/audio/host-legacy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
struct comp_buffer *sink;
int ret;
bool update_mailbox = false;
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
bool send_ipc = false;
#endif

if (dev->direction == SOF_IPC_STREAM_PLAYBACK) {
source = hd->dma_buffer;
Expand Down Expand Up @@ -272,6 +274,7 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
if (hd->cont_update_posn)
update_mailbox = true;

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
/* Don't send stream position if no_stream_position == 1 */
if (!hd->no_stream_position) {
hd->report_pos += bytes;
Expand All @@ -291,13 +294,16 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
send_ipc = true;
}
}
#endif

if (update_mailbox) {
pipeline_get_timestamp(dev->pipeline, dev, &hd->posn);
mailbox_stream_write(dev->pipeline->posn_offset,
&hd->posn, sizeof(hd->posn));
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
if (send_ipc)
ipc_msg_send(hd->msg, &hd->posn, false);
#endif
}
}

Expand Down Expand Up @@ -553,12 +559,14 @@ int host_common_new(struct host_data *hd, struct comp_dev *dev,

ipc_build_stream_posn(&hd->posn, SOF_IPC_STREAM_POSITION, config_id);

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
hd->msg = ipc_msg_init(hd->posn.rhdr.hdr.cmd, hd->posn.rhdr.hdr.size);
if (!hd->msg) {
comp_err(dev, "ipc_msg_init failed");
dma_put(hd->dma);
return -ENOMEM;
}
#endif
hd->chan = NULL;
hd->copy_type = COMP_COPY_NORMAL;

Expand Down Expand Up @@ -614,7 +622,9 @@ void host_common_free(struct host_data *hd)

dma_put(hd->dma);

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
ipc_msg_free(hd->msg);
#endif
dma_sg_free(NULL, &hd->config.elem_array);
}

Expand Down Expand Up @@ -952,7 +962,9 @@ void host_common_reset(struct host_data *hd, uint16_t state)

/* reset buffer pointers */
hd->local_pos = 0;
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
hd->report_pos = 0;
#endif
hd->total_data_processed = 0;

hd->copy_type = COMP_COPY_NORMAL;
Expand Down
14 changes: 13 additions & 1 deletion src/audio/host-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
struct comp_buffer *sink;
int ret;
bool update_mailbox = false;
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
bool send_ipc = false;
#endif

if (dev->direction == SOF_IPC_STREAM_PLAYBACK) {
source = hd->dma_buffer;
Expand Down Expand Up @@ -285,6 +287,7 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
if (hd->cont_update_posn)
update_mailbox = true;

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
/* Don't send stream position if no_stream_position == 1 */
if (!hd->no_stream_position) {
hd->report_pos += bytes;
Expand All @@ -304,13 +307,16 @@ void host_common_update(struct host_data *hd, struct comp_dev *dev, uint32_t byt
send_ipc = true;
}
}
#endif

if (update_mailbox) {
pipeline_get_timestamp(dev->pipeline, dev, &hd->posn);
mailbox_stream_write(dev->pipeline->posn_offset,
&hd->posn, sizeof(hd->posn));
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
if (send_ipc)
ipc_msg_send(hd->msg, &hd->posn, false);
#endif
}
}

Expand Down Expand Up @@ -720,14 +726,16 @@ __cold int host_common_new(struct host_data *hd, struct comp_dev *dev,
dma_sg_init(&hd->local.elem_array);

ipc_build_stream_posn(&hd->posn, SOF_IPC_STREAM_POSITION, config_id);
hd->chan_index = -EINVAL;

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
hd->msg = ipc_msg_init(hd->posn.rhdr.hdr.cmd, sizeof(hd->posn));
if (!hd->msg) {
comp_err(dev, "ipc_msg_init failed");
sof_dma_put(hd->dma);
return -ENOMEM;
}
hd->chan_index = -EINVAL;
#endif
hd->copy_type = COMP_COPY_NORMAL;

#ifdef CONFIG_SOF_USERSPACE_LL
Expand Down Expand Up @@ -808,7 +816,9 @@ __cold void host_common_free(struct host_data *hd)

sof_dma_put(hd->dma);

#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
ipc_msg_free(hd->msg);
#endif
dma_sg_free(hd->alloc_ctx.heap, &hd->config.elem_array);
}

Expand Down Expand Up @@ -1212,7 +1222,9 @@ void host_common_reset(struct host_data *hd, uint16_t state)

/* reset buffer pointers */
hd->local_pos = 0;
#if CONFIG_HOST_DMA_IPC_POSITION_UPDATES
hd->report_pos = 0;
#endif
hd->total_data_processed = 0;

hd->copy_type = COMP_COPY_NORMAL;
Expand Down
Loading