audio: host-zephyr: make component usable from user-space#10799
Open
kv2019i wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
For context, part of #10558 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Zephyr host audio component to consistently pass an allocation context/heap into memory allocation APIs, enabling the component to run correctly in both kernel and user-space.
Changes:
- Add
alloc_ctxtostruct host_datato carry allocation context information. - Use
hd->alloc_ctx.heapwhen allocating/freeing DMA scatter-gather elements and DMA-related configs. - Initialize
hd->alloc_ctx.heapfor user-space low-latency builds viazephyr_ll_user_heap().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/audio/host-zephyr.c | Routes allocations/frees through hd->alloc_ctx.heap and sets user-space heap under CONFIG_SOF_USERSPACE_LL. |
| src/audio/copier/host_copier.h | Adds struct mod_alloc_ctx alloc_ctx to struct host_data. |
Ensure an allocation context object is passed correctly whenever memory is allocated in the component. This allows to run the component both in kernel and user space. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
d20c1b8 to
ade5256
Compare
Collaborator
Author
|
V2 pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure an allocation context object is passed correctly whenever memory is allocated in the component. This allows to run the component both in kernel and user space.