module: passthrough: rework module to use sink/source api#10789
Open
softwarecki wants to merge 1 commit into
Open
module: passthrough: rework module to use sink/source api#10789softwarecki wants to merge 1 commit into
softwarecki wants to merge 1 commit into
Conversation
Rework the passthrough module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
serhiy-katsyuba-intel
approved these changes
May 18, 2026
tmleman
approved these changes
May 19, 2026
lyakh
reviewed
May 19, 2026
| } | ||
| source_release_data(sources[0], n_bytes); | ||
|
|
||
| memcpy_s(codec->mpd.out_buff, codec->mpd.out_buff_size, codec->mpd.in_buff, n_bytes); |
Collaborator
There was a problem hiding this comment.
are .in_buff and .out_buff temporary buffers? Looks like at least one of them could be eliminated, e.g. simply by removing this memcpy() and copying directly from .in_buff below. Maybe even both could be eliminated. But this doesn't have to be solved in this PR and maybe I'm mistaken entirely and those intermediate buffers have other roles too.
Collaborator
Author
There was a problem hiding this comment.
I think this is a sample module, a template for future codecs. Instead of memcpy, somebody could simply insert own processing function. The waves module uses this template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the passthrough module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0.