module_adapter: ipc4: validate pin counts against IPC4 maximum#10787
Open
abonislawski wants to merge 3 commits into
Open
module_adapter: ipc4: validate pin counts against IPC4 maximum#10787abonislawski wants to merge 3 commits into
abonislawski wants to merge 3 commits into
Conversation
Remove the repeated 'count' in the IPC4_MAX_SRC_QUEUE comment. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Add IPC4_MAX_DST_QUEUE (value 8) as the symmetric counterpart to IPC4_MAX_SRC_QUEUE, representing the maximum destination/output pin queue count supported by the IPC4 protocol. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds upper-bound validation for IPC4 module init pin counts so that values exceeding the IPC4 protocol maximum (8) are rejected before being stored and used downstream, complementing the existing exact cfgsz check.
Changes:
- Define new
IPC4_MAX_DST_QUEUEconstant (8) and fix a duplicated word ("count count") in the existingIPC4_MAX_SRC_QUEUEcomment. - Validate
nb_input_pins/nb_output_pinsagainstIPC4_MAX_SRC_QUEUE/IPC4_MAX_DST_QUEUEinmodule_adapter_init_data()and return-EINVALif exceeded. - Include
<ipc4/base_fw.h>inmodule_adapter_ipc4.cfor the new constants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/include/ipc4/base_fw.h | Adds IPC4_MAX_DST_QUEUE macro and corrects a comment typo. |
| src/audio/module_adapter/module_adapter_ipc4.c | Includes base_fw.h and rejects pin counts exceeding IPC4 maxima before computing pinsz. |
tmleman
approved these changes
May 18, 2026
Reject IPC4 module init payloads where nb_input_pins or nb_output_pins exceed the protocol maximum (IPC4_MAX_SRC_QUEUE / IPC4_MAX_DST_QUEUE = 8). The existing cfgsz equality check ensures the immediate pointer arithmetic is in-bounds, but it does not prevent unsupported pin counts from being stored in dst->nb_input_pins / dst->nb_output_pins and used by downstream module code. Add explicit upper-bound validation before computing pinsz, matching the IPC4 ABI contract advertised via IPC4_MAX_MODULE_PIN_COUNT_FW_CFG. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
0b214bb to
bb16604
Compare
Member
Author
|
Update: I moved the check two lines down. It was accidentally in the wrong place and this was caught by the testbench and CI. |
lgirdwood
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject IPC4 module init payloads where nb_input_pins or nb_output_pins
exceed the protocol maximum (IPC4_MAX_SRC_QUEUE / IPC4_MAX_DST_QUEUE = 8).
The existing cfgsz equality check ensures the immediate pointer
arithmetic is in-bounds, but it does not prevent unsupported pin counts
from being stored in dst->nb_input_pins / dst->nb_output_pins and used
by downstream module code. Add explicit upper-bound validation before
computing pinsz, matching the IPC4 ABI contract advertised via
IPC4_MAX_MODULE_PIN_COUNT_FW_CFG.