Skip to content

ASoC: SOF: Fixes forIPC4 compressed stream support #5892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujfalusi wants to merge 6 commits into
base: topic/sof-dev
Choose a base branch
from
Open

ASoC: SOF: Fixes forIPC4 compressed stream support #5892

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb65cb1
fixup! ASoC: SOF: sof-audio: harden recursive widget free walk
ujfalusi Aug 24, 2026
64a796f
fixup! ASoC: SOF: ipc4-topology: Support init_ext_module_data for pro…
ujfalusi Aug 24, 2026
8d835d3
Revert "ASoC: soc-pcm: Allocate be_substream->runtime for compressed …
ujfalusi Aug 24, 2026
3cc7fe9
ASoC: soc-compress: Provide a runtime for the compressed FE substream
ujfalusi Aug 24, 2026
e050c91
fixup! ASoC: SOF: Add support for IPC4 compressed
ujfalusi Aug 24, 2026
33c0334
fixup! ASoC: SOF: Add support for IPC4 compressed
ujfalusi Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "ASoC: soc-pcm: Allocate be_substream->runtime for compressed … 
…streams"

This reverts commit 89a7244.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
  • Loading branch information
@ujfalusi
ujfalusi committed Aug 24, 2026
commit 8d835d3f5192c10132ffe78b3cf54a11d8c548de
34 changes: 8 additions & 26 deletions sound/soc/soc-pcm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,8 +1790,6 @@ void dpcm_be_dai_stop(struct snd_soc_pcm_runtime *fe, int stream,
}

__soc_pcm_close(be, be_substream);
if (fe->fe_compr)
kfree(be_substream->runtime);
be_substream->runtime = NULL;
be->dpcm[stream].state = SND_SOC_DPCM_STATE_CLOSE;
}
Expand Down Expand Up @@ -1839,26 +1837,18 @@ int dpcm_be_dai_startup(struct snd_soc_pcm_runtime *fe, int stream)
dev_dbg(be->dev, "ASoC: open %s BE %s\n",
snd_pcm_direction_name(stream), be->dai_link->name);

if (!fe->fe_compr) {
be_substream->runtime = fe_substream->runtime;
} else {
be_substream->runtime = kzalloc(sizeof(*be_substream->runtime),
GFP_KERNEL);
if (!be_substream->runtime) {
err = -ENOMEM;
goto unwind;
}
}

be_substream->runtime = fe_substream->runtime;
err = __soc_pcm_open(be, be_substream);
if (err < 0) {
if (fe->fe_compr) {
kfree(be_substream->runtime);
be_substream->runtime = NULL;
}
be->dpcm[stream].users--;
if (be->dpcm[stream].users < 0)
dev_err(be->dev, "ASoC: no users %s at unwind %s\n",
snd_pcm_direction_name(stream),
dpcm_state_string(be->dpcm[stream].state));

be->dpcm[stream].state = SND_SOC_DPCM_STATE_CLOSE;
goto unwind;
}

be->dpcm[stream].be_start = 0;
be->dpcm[stream].state = SND_SOC_DPCM_STATE_OPEN;
count++;
Expand All @@ -1867,14 +1857,6 @@ int dpcm_be_dai_startup(struct snd_soc_pcm_runtime *fe, int stream)
return count;

unwind:
be->dpcm[stream].users--;
if (be->dpcm[stream].users < 0)
dev_err(be->dev, "ASoC: no users %s at unwind %s\n",
snd_pcm_direction_name(stream),
dpcm_state_string(be->dpcm[stream].state));

be->dpcm[stream].state = SND_SOC_DPCM_STATE_CLOSE;

dpcm_be_dai_startup_rollback(fe, stream, dpcm);

return soc_pcm_ret(fe, err);
Expand Down