Skip json_last_error check when JSON_THROW_ON_ERROR flag is set in json_decode#451
Merged
Merged
Conversation
9c69d1a to
3cbf367
Compare
json_last_error check when JSON_THROW_ON_ERROR flag is set in json_decode
Collaborator
|
thank you |
This was referenced Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles a rather unpleasant quirk in PHP where if
json_decodeis called withoutJSON_THROW_ON_ERROR_FLAGfor an invalid json string before callingjson_decodefor a valid json string with said flag thejson_error_lastmethod will report the error from the first call, instead of being reset on the second.I've implemented a simple test to illustrate how this happens.
https://bugs.php.net/bug.php?id=77997
Also found this: #437 (comment)