Use @param tags from constructor with property promotion#628
Merged
oojacoboo merged 6 commits intoOct 16, 2023
Merged
Conversation
… for a property, use the constructor docblock as fallback when an @var isn't available
Collaborator
Author
|
Should be ready. A review would be nice. |
andrew-demb
reviewed
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using property promotion, particularly with input types, you're required to define the generic type details for lists (array, collection, etc) using a variable docblock. Not only is this ugly, it requires duplicate docblock definitions for internal docblock usage and is entirely unnecessary.
This PR adds support for constructor docblock generic type definitions with property promotion.
Example:
As opposed to:
The additional support is fully BC.