csv_file_update_from_upload_section/src/main/java/com/testsigma/addons/web/WriteCsvFileandStorePath.java (1)

169-175: Filename fix is correct; consider a collision-safe variant.

The "temp_" + millis + ".csv" pattern correctly breaks the recursive embedding of encoded paths that produced the 255-byte filename overflow. As an optional hardening step, two parallel executions hitting convertToFile within the same millisecond would produce the same temp path and race on copyURLToFile (one download could overwrite a sibling's file mid-read). Using Files.createTempFile or appending UUID.randomUUID()/nanoTime() eliminates that race.

♻️ Optional — collision-safe temp file

-            String uniqueFileName = "temp_" + System.currentTimeMillis() + ".csv";
-            logger.info("Given is a URL... Original file name: " + originalFileName + ", Unique file name: "
-                    + uniqueFileName);
-
-            // Create the full path for the temporary file
-            String filePath = String.format("%s%s%s", FileUtils.getTempDirectoryPath(), File.separator, uniqueFileName);
-            File tempFile = new File(filePath);
+            File tempFile = Files.createTempFile("temp_", ".csv").toFile();
+            logger.info("Given is a URL... Original file name: " + originalFileName
+                    + ", Unique file name: " + tempFile.getName());

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@csv_file_update_from_upload_section/src/main/java/com/testsigma/addons/web/WriteCsvFileandStorePath.java`
around lines 169 - 175, The current uniqueFileName generation in
WriteCsvFileandStorePath (variable uniqueFileName inside convertToFile handling
the URL path) uses "temp_"+System.currentTimeMillis()+".csv" which can collide
if called multiple times in the same millisecond; change it to a collision-safe
temp file creation strategy — either use Files.createTempFile(...) to get a
guaranteed-unique temp path or append a UUID (e.g. UUID.randomUUID()) or
System.nanoTime() to the generated name before using it with copyURLToFile;
update any logging that references uniqueFileName accordingly (logger.info
lines) to reflect the new approach.

csv_file_update_from_upload_section/src/main/java/com/testsigma/addons/web/DeleteRowContentFromCsvAndStorePath.java (1)

80-87: Dead null check on csvFile.

convertToFile either returns a new File(...) or throws — it never returns null. The csvFile == null half of the guard is dead and can be removed for clarity. The !csvFile.exists() check is still useful and should stay.

♻️ Proposed simplification

-            if (csvFile == null || !csvFile.exists()) {
+            if (!csvFile.exists()) {
                 setErrorMessage("CSV File not found or could not be downloaded: " + filePathString);
                 return com.testsigma.sdk.Result.FAILED;
             }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@csv_file_update_from_upload_section/src/main/java/com/testsigma/addons/web/DeleteRowContentFromCsvAndStorePath.java`
around lines 80 - 87, The null check on csvFile is dead because convertToFile
either returns a File or throws; update the block in
DeleteRowContentFromCsvAndStorePath so you remove the "csvFile == null ||" part
and only check "!csvFile.exists()"; keep the call to
convertToFile(filePathString), retain logger.info("CSV file path: " +
csvFile.getAbsolutePath()), and keep setErrorMessage(...) and return
com.testsigma.sdk.Result.FAILED when the file does not exist.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes