Skip to content

chore(lint): update typing and linting#425

Merged
totallyzen merged 14 commits intotestcontainers:mainfrom
totallyzen:feat/update-typing-and-linting
Feb 21, 2024
Merged

chore(lint): update typing and linting#425
totallyzen merged 14 commits intotestcontainers:mainfrom
totallyzen:feat/update-typing-and-linting

Conversation

@totallyzen
Copy link
Copy Markdown
Contributor

@totallyzen totallyzen commented Feb 19, 2024

change

advances #305

  • replace flake8 with ruff and install pre-commit
  • run linters as part of a separate job (to separate linting from testing)
  • add a draft of mypy setup but not try to fix stuff because it's a complicated procedure to fix everything - this PR already reformatted a lot of code

@totallyzen totallyzen changed the title Feat/update typing and linting chore(lint): update typing and linting Feb 20, 2024
@alexanderankin
Copy link
Copy Markdown
Member

https://github.com/testcontainers/testcontainers-python/actions/runs/7979817068/job/21788105968?pr=425#step:8:29 - hopefully fixed in #428 but at any rate doesn't need to be fixed here

@totallyzen totallyzen merged commit 098db15 into testcontainers:main Feb 21, 2024
@totallyzen totallyzen deleted the feat/update-typing-and-linting branch February 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants