feat: Add proper support for Keycloak#369
Closed
TheForgottened wants to merge 2 commits intotestcontainers:mainfrom
Closed
feat: Add proper support for Keycloak#369TheForgottened wants to merge 2 commits intotestcontainers:mainfrom
TheForgottened wants to merge 2 commits intotestcontainers:mainfrom
Conversation
Author
|
@timbmg anything missing on the PR that's stopping it from being merged? |
Contributor
|
@timbmg do you have the power to rerun the actions? I actually would like to use these changes, so would be nice if we could get them merged. |
Member
|
Thanks for your contribution, @TheForgottened . Currently, we are not able to maintain the module but there is an Module Catalog, which also list community modules from this repository. I think it would be great if the repository can be hosted under https://github.com/keycloak. /cc @stianst |
|
@TheForgottened great contribution! would you be able to submit this to the Keycloak org as proposed by @eddumelendez? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testcontainers library is giving support for a deprecated image of Keycloak.
This PR aims to give support to the new image of Keycloak, making sure it works independently of the tag used.
This has proved to be more difficult than it should've because of many reasons:
The code works 100% fine according to my tests and the tests added. I haven't tested with the legacy image tbh, but I have a hunch it might just work, except for version 17 and up.