Skip to content

Add minio container - #271

Merged
tillahoffmann merged 14 commits into
testcontainers:masterfrom
maltehedderich:add-minio-container
Dec 7, 2022
Merged

Add minio container#271
tillahoffmann merged 14 commits into
testcontainers:masterfrom
maltehedderich:add-minio-container

Conversation

@maltehedderich

@maltehedderich maltehedderich commented Dec 4, 2022

Copy link
Copy Markdown
Contributor

Container Contribution Checklist:

  • You have added the new container as a module in the testcontainers directory (such as testcontainers/my_fancy_container.py).
  • You have added any new python dependencies in the extras_require section of setup.py.
  • You have added the extra_requires key to requirements.in.
  • You have updated all python requirements by running make requirements from the root directory.
  • You have added tests for the new container in the tests directory, e.g. tests/test_my_fancy_container.py.
  • You have added the name of the container (such as my_fancy_container) to the test-components matrix in .github/workflows/main.yml to ensure the tests are run.
  • You have rebased your development branch on master (or merged master into your development branch).

tillahoffmann
tillahoffmann reviewed Dec 6, 2022
View reviewed changes
Comment thread testcontainers/minio.py Outdated
tillahoffmann
tillahoffmann reviewed Dec 6, 2022
View reviewed changes
Comment thread testcontainers/minio.py
@codecov-commenter

codecov-commenter commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #271 (a50f4d9) into master (28e3a47) will increase coverage by 0.52%.
The diff coverage is 100.00%.

❗ Current head a50f4d9 differs from pull request most recent head cc6cf7b. Consider uploading reports for the commit cc6cf7b to get more accurate results

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   86.20%   86.73%   +0.52%     
==========================================
  Files          28       29       +1     
  Lines         783      814      +31     
  Branches       57       57              
==========================================
+ Hits          675      706      +31     
  Misses         78       78              
  Partials       30       30
Impacted Files Coverage Δ
testcontainers/minio.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tillahoffmann
tillahoffmann merged commit bb65a01 into testcontainers:master Dec 7, 2022
@tillahoffmann

tillahoffmann commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

Thanks for the implementation.

@tillahoffmann tillahoffmann mentioned this pull request Dec 7, 2022
Closed
@maltehedderich
maltehedderich deleted the add-minio-container branch December 9, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tillahoffmann tillahoffmann tillahoffmann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maltehedderich @codecov-commenter @tillahoffmann