Skip to content

Fix None/True/False handling in Arango. - #222

Merged
tillahoffmann merged 3 commits into
testcontainers:masterfrom
tillahoffmann:arango-fix
Jun 14, 2022
Merged

Fix None/True/False handling in Arango.#222
tillahoffmann merged 3 commits into
testcontainers:masterfrom
tillahoffmann:arango-fix

Conversation

@tillahoffmann

@tillahoffmann tillahoffmann commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Minor changes to let None default to environment variables and True/False to be used as is. Cf. #221.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #222 (3f720fa) into master (c0dc701) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   86.52%   86.56%   +0.03%     
==========================================
  Files          27       27              
  Lines         720      722       +2     
  Branches       65       65              
==========================================
+ Hits          623      625       +2     
  Misses         76       76              
  Partials       21       21              
Impacted Files Coverage Δ
testcontainers/arangodb.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc701...3f720fa. Read the comment docs.

@tillahoffmann
tillahoffmann merged commit 99a3252 into testcontainers:master Jun 14, 2022
@tillahoffmann
tillahoffmann deleted the arango-fix branch June 14, 2022 19:40
@nshine

nshine commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Hi @tillahoffmann / @thedrow / @SergeyPirogov
Can you please trigger new release ?

@tillahoffmann

Copy link
Copy Markdown
Contributor Author

@nshine, that should already be done. Let me know if you have a problem installing 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants