Skip to content

Set lower bound on docker version#181

Closed
naomielst wants to merge 3 commits intotestcontainers:masterfrom
naomielst:patch-1
Closed

Set lower bound on docker version#181
naomielst wants to merge 3 commits intotestcontainers:masterfrom
naomielst:patch-1

Conversation

@naomielst
Copy link
Copy Markdown
Contributor

From my experience, the docker version must be >= 4.0.0

From my experience, the docker version must be >= 4.0.0
@tillahoffmann
Copy link
Copy Markdown
Contributor

This will also need a rebuild of the requirements (cf. #188). The motivation behind completely pinning down the requirements for tests is to be able to separate "issues caused by dependency versions changing" from "issues introduced in a PR".

@tillahoffmann tillahoffmann marked this pull request as draft March 26, 2022 21:17
@thedrow
Copy link
Copy Markdown

thedrow commented Mar 29, 2022

This will also need a rebuild of the requirements (cf. #188). The motivation behind completely pinning down the requirements for tests is to be able to separate "issues caused by dependency versions changing" from "issues introduced in a PR".

I suggest using something like poetry instead and caching the lock file.

@tillahoffmann
Copy link
Copy Markdown
Contributor

I suggest using something like poetry instead and caching the lock file.

Yup, those requirements are locked down dependencies. We just generate them using pip-tools rather than poetry or pipenv.

@thedrow thedrow marked this pull request as ready for review April 10, 2022 12:00
@thedrow
Copy link
Copy Markdown

thedrow commented Apr 10, 2022

@tillahoffmann Would you mind doing it this time?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #181 (89fe178) into master (8119ccc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          25       25           
  Lines         670      670           
  Branches       60       60           
=======================================
  Hits          574      574           
  Misses         76       76           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8119ccc...89fe178. Read the comment docs.

@tillahoffmann
Copy link
Copy Markdown
Contributor

See #203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants