Skip to content

Fix Couchbase FTS support - #2350

Closed
tchlyah wants to merge 9 commits into
testcontainers:masterfrom
tchlyah:couchbase-fts
Closed

Fix Couchbase FTS support#2350
tchlyah wants to merge 9 commits into
testcontainers:masterfrom
tchlyah:couchbase-fts

Conversation

@tchlyah

@tchlyah tchlyah commented Feb 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add fts_admin user role
  • Wait for the FTS service to be up
  • Add FTS tests for Couchbase 6.0 and 6.5

bsideup
bsideup requested changes Feb 12, 2020
View reviewed changes
Comment thread modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseServiceWaitStrategy.java Outdated
@tchlyah

tchlyah commented Feb 13, 2020

Copy link
Copy Markdown
Contributor Author

Hello! When do you think this will be merged and delivered? I need this in order to add FTS compatibility to Couchmove

@tchlyah
tchlyah requested a review from bsideup February 14, 2020 10:17
@tchlyah

tchlyah commented Feb 19, 2020

Copy link
Copy Markdown
Contributor Author

I don't understand why checks are failing, the test are ok locally, and the ones that are failing doesn't have any relation with my updates. Can someone take a look into that ?

This was referenced Feb 25, 2020
Merged
Merged
@tchlyah

tchlyah commented Mar 11, 2020

Copy link
Copy Markdown
Contributor Author

@bsideup @rnorth @kiview Can you please help on this ? It's small improvements and it is blocking both tchlyah/couchmove#5 and jhipster/generator-jhipster#11421!

bsideup
bsideup reviewed Mar 13, 2020
View reviewed changes
Comment thread modules/couchbase/src/test/java/org/testcontainers/couchbase/Couchbase6_0Test.java Outdated
@tchlyah
tchlyah requested a review from bsideup March 17, 2020 13:02
@tchlyah tchlyah mentioned this pull request Mar 23, 2020
Closed
1 task
@tchlyah

tchlyah commented Mar 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Is there still any blocking issue here?

@tchlyah

tchlyah commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

I don't understand why this is still open, it is small fix and blocking 2 PR! Can you please take a look ?

@bsideup

bsideup commented Apr 3, 2020

Copy link
Copy Markdown
Member

@tchlyah we're reworking the Couchbase container (see #2491), could you please take a look at that PR? It comes with FTS service support.

@tchlyah tchlyah closed this Apr 18, 2020
@tchlyah
tchlyah deleted the couchbase-fts branch April 18, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiview kiview Awaiting requested review from kiview
@rnorth rnorth Awaiting requested review from rnorth
@bsideup bsideup Awaiting requested review from bsideup

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tchlyah @bsideup