Skip to content

fix(build): declare explicit task dependencies for Gradle 8 strict validation #11836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiview wants to merge 1 commit into from
+26 −2
Closed

fix(build): declare explicit task dependencies for Gradle 8 strict validation #11836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions gradle/shading.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,34 @@ project.afterEvaluate {
}

// Add shaded JARs first
tasks.test.classpath = findShadedProjects(project)
.plus(project)
def shadedProjects = findShadedProjects(project).plus(project)
tasks.test.classpath = shadedProjects
.sum { it.tasks.findByName("shadowJar").outputs.files }
.plus(sourceSets.test.runtimeClasspath)

// Gradle 8: declare explicit task dependencies for all jar/shadowJar tasks whose outputs
// are added to the test classpath, to satisfy strict implicit dependency validation.
// Both jar and shadowJar must be declared because non-published modules (e.g. test-support,
// docs examples) do not set jar.archiveClassifier, so both tasks write the same filename.
shadedProjects.each { p ->
def shadowJarTask = p.tasks.findByName("shadowJar")
if (shadowJarTask != null) {
tasks.test.dependsOn(shadowJarTask)
}
def jarTask = p.tasks.findByName("jar")
if (jarTask != null) {
tasks.test.dependsOn(jarTask)
}
}

// Also declare explicit dependency on shadowJar tasks from testImplementation project
// dependencies, since their shadowJar output (classifier=null) is the resolved artifact.
configurations.testImplementation.dependencies.withType(ProjectDependency).each { dep ->
def shadowJarTask = dep.dependencyProject.tasks.findByName("shadowJar")
if (shadowJarTask != null) {
tasks.test.dependsOn(shadowJarTask)
}
}
}

static Set<Project> findShadedProjects(Project project) {
Expand Down
Loading