Skip to content

[Docs] Correct regex documentation example for property mangling#477

Merged
fabiosantoscode merged 1 commit into
terser:masterfrom
perry-mitchell:patch-1
Oct 5, 2019
Merged

[Docs] Correct regex documentation example for property mangling#477
fabiosantoscode merged 1 commit into
terser:masterfrom
perry-mitchell:patch-1

Conversation

@perry-mitchell
Copy link
Copy Markdown
Contributor

@perry-mitchell perry-mitchell commented Oct 1, 2019

Thought that the text should say end rather than start, as $ denotes end-of-string rather than the beginning.

@L2jLiga
Copy link
Copy Markdown
Contributor

L2jLiga commented Oct 1, 2019

I think this one relates to #336

@perry-mitchell
Copy link
Copy Markdown
Contributor Author

Sure, though I think the other PR took the more complicated route - changing terminology seemed to be simple enough. I didn’t notice the other Pr first however..

@fabiosantoscode
Copy link
Copy Markdown
Collaborator

Thanks! Yeah, this is a simpler route. It's a bit weird that the docs explain how to mangle properties ending with _ since commonly it's properties starting with a _ that are deemed private. But that's beside the point lol.

@fabiosantoscode fabiosantoscode merged commit 22f9d9a into terser:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants